Implement Response.IsError #24122
Merged
Implement Response.IsError #24122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
annelo-msft
requested review from
KrzysztofCwalina,
pakrym and
tg-msft
as code owners
pakrym
reviewed
Sep 20, 2021
pakrym
reviewed
Sep 20, 2021
pakrym
reviewed
Sep 21, 2021
pakrym
reviewed
Sep 21, 2021
pakrym
reviewed
Sep 21, 2021
pakrym
approved these changes
Sep 22, 2021
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #23372 (comment), we'll add an
IsErrorproperty toResponse. This is currently being implemented as an extension method in Experimental as a proof of concept before moving it into Azure.Core.IsErrormust be set beforeRequestis disposed because it takes theHttpMessage. We also want to make the value ofIsErroravailable onResponsein the pipeline, so we callEvaluateError()in a pipeline policy just after the response is received by the transport.Per @pakrym, client request id can be set on response in the same pipeline policy.