Adding Retries for InstallationCheck #23792

ckairen · 2021-09-03T23:22:24Z

This enables InstallationCheck to rerun for 30 minutes, in case of when multiple packages are released from the same pipeline.

Pipeline Reference:
This one retries for 3 times before getting the correct version:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1081546&view=logs&j=3c922a7d-1305-5297-ba3f-884e0ad84366&t=ad177618-4778-5c7a-f9e0-5bf485085f93&l=920

This is a successful run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1081550&view=logs&j=3c922a7d-1305-5297-ba3f-884e0ad84366&t=ad177618-4778-5c7a-f9e0-5bf485085f93&l=922

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

eng/scripts/InstallationCheck.ps1

eng/pipelines/templates/stages/archetype-net-release.yml

eng/scripts/InstallationCheck.ps1

weshaggard · 2021-09-07T20:23:28Z

eng/pipelines/templates/stages/archetype-net-release.yml

@@ -80,6 +70,10 @@ stages:
                        PackageName: ${{artifact.name}}
                        ServiceName: ${{parameters.ServiceDirectory}}
                        ForRelease: true
+                    - pwsh: |


Given this is just calling a single script lets switch it to using the powershell tasks instead of the pwsh shortcut. See https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/2/Azure-DevOps-Pipeline-Guidance?anchor=devops-tasks-vs-pwsh-script-shortcut for more info.

weshaggard · 2021-09-07T20:25:09Z

eng/scripts/InstallationCheck.ps1

@@ -6,27 +6,39 @@ param (
    [string] $Artifact,

    [Parameter()]
-    [string] $PipelineWorkspace
+    [string] $PipelineWorkspace,


Doesn't look like we need or use the PipelineWorkspace variable any longer so we should remove it.

weshaggard

One last clean-up but otherwise looks good.

weshaggard · 2021-09-07T22:50:09Z

eng/pipelines/templates/stages/archetype-net-release.yml

@@ -80,6 +70,14 @@ stages:
                        PackageName: ${{artifact.name}}
                        ServiceName: ${{parameters.ServiceDirectory}}
                        ForRelease: true
+                    - task: PowerShell@2
+                      inputs:


You will also want to add pwsh: true so that it uses powershell core instead of windows powershell.

Release microsoft.api management 2023 03 01 preview (Azure#23792) * Adds base for updating Microsoft.ApiManagement from version preview/2022-09-01-preview to version 2023-03-01-preview * Updates readme * Updates API version in new specs and examples * feat(apim): Provide capability to use custom hostname for Configuration API v2 (Azure#23785) Signed-off-by: Tom Kerkhove <[email protected]> * feat(rp): Added flags to enable/disable portals (Azure#23799) * feat(rp): Added flags to enable/disable portals * update default * feat(apim): Provide capability to disable legacy configuration API (Azure#23786) * feat(apim): Provide capability to disable legacy configuration API Signed-off-by: Tom Kerkhove <[email protected]> * Update sample Signed-off-by: Tom Kerkhove <[email protected]> * Fix type definition Signed-off-by: Tom Kerkhove <[email protected]> * Switch to enum Signed-off-by: Tom Kerkhove <[email protected]> * Update samples Signed-off-by: Tom Kerkhove <[email protected]> --------- Signed-off-by: Tom Kerkhove <[email protected]> * feat(apim): Add new tracing API (Azure#23800) * Add new tracing api * Remove TODOs descriptions * Improve descriptions * Fix dot * Add missing examples * prettier fixes * Fix model and semantic problems * Remove get prefix in post operations * Use list prefix * Fix PR comments * feat(apim): Add ability to create and update new OData api (Azure#23849) * Add odata api definitions * add api usage example * fix file reference * address comments --------- Co-authored-by: rkolesnikov <[email protected]> * migration contract (Azure#23983) * 2023 03 cred scan fix - Examples Only (Azure#24357) * remove-sas-signature * update example * 2023-03-01-preview arm review feedback (Azure#24404) * move to v5 subscription contract * move to v5 for rg and api-version * cred scan * default is true * uuid in examples * change from boolean to enums * fix default value --------- Signed-off-by: Tom Kerkhove <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Co-authored-by: Harun Reşit <[email protected]> Co-authored-by: Rafał Mielowski <[email protected]> Co-authored-by: Roman Kolesnikov <[email protected]> Co-authored-by: rkolesnikov <[email protected]>

Adding Retries for InstallationCheck

d592a69

ckairen linked an issue Sep 3, 2021 that may be closed by this pull request

Installation check should do retries #23739

Closed

ckairen marked this pull request as ready for review September 3, 2021 23:24

ckairen requested review from chidozieononiwu, danieljurek and weshaggard as code owners September 3, 2021 23:24

pakrym reviewed Sep 3, 2021

View reviewed changes

eng/scripts/InstallationCheck.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Sep 3, 2021

View reviewed changes

eng/pipelines/templates/stages/archetype-net-release.yml Outdated Show resolved Hide resolved

weshaggard reviewed Sep 3, 2021

View reviewed changes

eng/scripts/InstallationCheck.ps1 Show resolved Hide resolved

weshaggard reviewed Sep 3, 2021

View reviewed changes

eng/scripts/InstallationCheck.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Sep 3, 2021

View reviewed changes

eng/scripts/InstallationCheck.ps1 Outdated Show resolved Hide resolved

PR fix

0e12865

weshaggard reviewed Sep 7, 2021

View reviewed changes

weshaggard approved these changes Sep 7, 2021

View reviewed changes

PR fix

03d0b8c

weshaggard reviewed Sep 7, 2021

View reviewed changes

ckairen added 2 commits September 7, 2021 16:10

PR fix

4bd9e0d

PR fix

f722b34

ckairen enabled auto-merge (squash) September 8, 2021 00:21

ckairen merged commit 19a3a3a into main Sep 8, 2021

ckairen deleted the albertcheng/ic-retry branch September 8, 2021 01:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Retries for InstallationCheck #23792

Adding Retries for InstallationCheck #23792

ckairen commented Sep 3, 2021

weshaggard Sep 7, 2021

weshaggard Sep 7, 2021

weshaggard left a comment

weshaggard Sep 7, 2021

Adding Retries for InstallationCheck #23792

Adding Retries for InstallationCheck #23792

Conversation

ckairen commented Sep 3, 2021

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

weshaggard Sep 7, 2021

Choose a reason for hiding this comment

weshaggard Sep 7, 2021

Choose a reason for hiding this comment

weshaggard left a comment

Choose a reason for hiding this comment

weshaggard Sep 7, 2021

Choose a reason for hiding this comment