-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mgmt track2 storage2 #23468
Merged
yukun-dong
merged 71 commits into
Azure:feature/mgmt-track2-storage
from
yukun-dong:feature/mgmt-track2-storage2
Aug 24, 2021
Merged
Feature/mgmt track2 storage2 #23468
yukun-dong
merged 71 commits into
Azure:feature/mgmt-track2-storage
from
yukun-dong:feature/mgmt-track2-storage2
Aug 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage merge with main
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
The focus of these changes is to cache JWT tokens used for authorization of AMQP connections and links to avoid making unnecesary requests due to network changes while the token is not near expiration. For features like Service Bus sessions, links can be opened/closed frequently, leading to a non-trivial amount of requests to acquire tokens that are likely to remain valid for the duration of their use. Also included is the addition of a small amount of random jitter when calculating the time that AMQP authorization should be resent; this is intended to reduce contention when a new token needs to be acquired.
* Add test and sample for custom serialization
* add test-proxy invocations to eng/common folder Co-authored-by: scbedd <[email protected]>
* doc change to GetLedgerEntries and addition of ParseCertificate
Co-authored-by: praveenkuttappan <[email protected]>
* Prepare for release * Update codeowners
Increment package version after release of Azure.Data.SchemaRegistry
* Make the accept session concurrency dynamic * PR FB
…ults.ps1 as it was no longer used (#23378) Co-authored-by: Chidozie Ononiwu <[email protected]>
…23377) * Update Microsoft.NETFramework.ReferenceAssemblies to latest version Recent agent updated version of VS which might have broken some targeting packs so testing to see if updating to the latest version helps. * Update Directory.Build.Common.props * Resolve PR feedback I want to merge this and rebase on it for my PR that is currently blocked. Co-authored-by: Heath Stewart <[email protected]>
* Update to Azure/azure-rest-api-specs@7a42f16 Resolves #22891 * Resolve PR feedback
…dential (#23388) * Produce more descriptive error for GenerateSasUri when using TokenCredential
* Make public API spell checking opt-out, opt out services which have errors * Opt eventhub in * Those with SpellCheckPublichApiSurface: true are already opted-in; remove. Opt out agrifood which has some false positives. * re-add service directory * Opt core out * Add personalizer and identity false positive exceptions and remove from the opt-out list * Add use of `--no-must-find-files` to usages of npx. This is not strictly necessary in aggregate-reports.yml, in that case it is meant to make invocation of cspell consistent * Opt out of public API surface spell checking * Update config: Opt out via cspell.json instead of ci.yml; Add 'dont' to the list of words so Core has zero spelling errors * Remove opt out from ci.yml * Remove SpellCheckPublicApiSurface parameter from ci.yml files, opt-out is handled in cspell.json * Use more restrictive globbing pattern in aggregate-reports.yml for spell checking. The previous pattern was including tests folders unnecessarily
* test-resources.json and test changes * exported api * rounded float * ignore body * added timeouts in test * consoladated tests * changes region for resources * moved resources to east us * added delay between update policy and get * merged all multislot tests * create resources in east us 2 * test-resources.json * changed test to address float rounding * moved test tesources to east us * movel resource to canary * changed resource location to centralus * added remove test resources post script * added line to eof * pr comments * changed resource deployment to eastus2euap Co-authored-by: orenmichaely <[email protected]>
m-nash
added a commit
that referenced
this pull request
Sep 1, 2021
* Feature/mgmt track2 storage2 (#23468) * generate code and add storage account test * add blob container test cases an record the test * modify azure manager version and regenerate code * regenerate code and add test cases * regenerate code and add queue, table test cases * regenerate code using remote spec and rerun tests * add Properties and change Helpers position * Add support for 'files' configuration (#23327) * add and change some test cases * add some storage account test cases * regenerate code using autorest c# v3.0.0 beta.20210825.1 * add some storage account test cases * modify some test cases * regenerate code using autorest c# v3.0.0-beta20210825.2 * update api * generate code using autorest c# v3.0.0-beta.20210826.2 * update api and README.md * update changelog * change README.md file * change README.md * bump storage version * modify samples' typos * modify samples and update snippets * regenerate using autorest c# 3.0.0-beta.20210830.1 * modify createResourceGroup method due to ResourceManager's version change * update snippets * add storage account test case * add one blob container test case * change mgmt storage version * fix compile errors in eventhub and network; modify typos in storage csproj file * fix merge conflicts * ignore storage account list key test * remove records that are not used * update with prepare release Co-authored-by: m-nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.