Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mgmt track2 storage2 #23468

Merged
merged 71 commits into from
Aug 24, 2021
Merged

Feature/mgmt track2 storage2 #23468

merged 71 commits into from
Aug 24, 2021

Conversation

yukun-dong
Copy link
Contributor

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

YukunDong and others added 30 commits August 12, 2021 15:35
The focus of these changes is to cache JWT tokens used for authorization
of AMQP connections and links to avoid making unnecesary requests due to network
changes while the token is not near expiration.

For features like Service Bus sessions, links can be opened/closed frequently,
leading to a non-trivial amount of requests to acquire tokens that are likely to
remain valid for the duration of their use.

Also included is the addition of a small amount of random jitter when calculating
the time that AMQP authorization should be resent; this is intended to reduce
contention when a new token needs to be acquired.
* Add test and sample for custom serialization
* add test-proxy invocations to eng/common folder

Co-authored-by: scbedd <[email protected]>
* doc change to GetLedgerEntries and addition of ParseCertificate
* Prepare for release

* Update codeowners
Increment package version after release of Azure.Data.SchemaRegistry
* Make the accept session concurrency dynamic

* PR FB
…ults.ps1 as it was no longer used (#23378)

Co-authored-by: Chidozie Ononiwu <[email protected]>
…23377)

* Update Microsoft.NETFramework.ReferenceAssemblies to latest version

Recent agent updated version of VS which might have broken some targeting packs so testing to see if updating to the latest version helps.

* Update Directory.Build.Common.props

* Resolve PR feedback

I want to merge this and rebase on it for my PR that is currently blocked.

Co-authored-by: Heath Stewart <[email protected]>
…dential (#23388)

* Produce more descriptive error for GenerateSasUri when using TokenCredential
* Make public API spell checking opt-out, opt out services which have errors

* Opt eventhub in

* Those with SpellCheckPublichApiSurface: true are already opted-in; remove. Opt out agrifood which has some false positives.

* re-add service directory

* Opt core out

* Add personalizer and identity false positive exceptions and remove from the opt-out list

* Add use of `--no-must-find-files` to usages of npx. This is not strictly necessary in aggregate-reports.yml, in that case it is meant to make invocation of cspell consistent

* Opt out of public API surface spell checking

* Update config: Opt out via cspell.json instead of ci.yml; Add 'dont' to the list of words so Core has zero spelling errors

* Remove opt out from ci.yml

* Remove SpellCheckPublicApiSurface parameter from ci.yml files, opt-out is handled in cspell.json

* Use more restrictive globbing pattern in aggregate-reports.yml for spell checking. The previous pattern was including tests folders unnecessarily
* test-resources.json and test changes

* exported api

* rounded float

* ignore body

* added timeouts in test

* consoladated tests

* changes region for resources

* moved resources to east us

* added delay between update policy and get

* merged all multislot tests

* create resources in east us 2

* test-resources.json

* changed test to address float rounding

* moved test tesources to east us

* movel resource to canary

* changed resource location to centralus

* added remove test resources post script

* added line to eof

* pr comments

* changed resource deployment to eastus2euap

Co-authored-by: orenmichaely <[email protected]>
@yukun-dong yukun-dong merged commit a2e5080 into Azure:feature/mgmt-track2-storage Aug 24, 2021
m-nash added a commit that referenced this pull request Sep 1, 2021
* Feature/mgmt track2 storage2 (#23468)

* generate code and add storage account test

* add blob container test cases an record the test

* modify azure manager version and regenerate code

* regenerate code and add test cases

* regenerate code and add queue, table test cases

* regenerate code using remote spec and rerun tests

* add Properties and change Helpers position

* Add support for 'files' configuration (#23327)

* add and change some test cases

* add some storage account test cases

* regenerate code using autorest c# v3.0.0 beta.20210825.1

* add some storage account test cases

* modify some test cases

* regenerate code using autorest c# v3.0.0-beta20210825.2

* update api

* generate code using autorest c# v3.0.0-beta.20210826.2

* update api and README.md

* update changelog

* change README.md file

* change README.md

* bump storage version

* modify samples' typos

* modify samples and update snippets

* regenerate using autorest c# 3.0.0-beta.20210830.1

* modify createResourceGroup method due to ResourceManager's version change

* update snippets

* add storage account test case

* add one blob container test case

* change mgmt storage version

* fix compile errors in eventhub and network; modify typos in storage csproj file

* fix merge conflicts

* ignore storage account list key test

* remove records that are not used

* update with prepare release

Co-authored-by: m-nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.