Rename LRO classes to be singular resource #23075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-nash
requested review from
archerzz,
ArcturusZhang,
fengzhou-msft and
yungezz
as code owners
ShivangiReja
reviewed
Aug 3, 2021
| @@ -20,18 +20,18 @@ namespace Azure.ResourceManager.Management.Models | |||
| /// If a management group is already created and a subsequent create request is issued with different properties, the management group properties will be updated. | |||
| /// . | |||
| /// </summary> | |||
| public partial class ManagementGroupsCreateOrUpdateOperation : Operation<ManagementGroup>, IOperationSource<ManagementGroup> | |||
| public partial class ManagementGroupCreateOrUpdateOperation : Operation<ManagementGroup>, IOperationSource<ManagementGroup> | |||
| { | |||
| private readonly OperationOrResponseInternals<ManagementGroup> _operation; | |||
|
|
|||
| private readonly ResourceOperations _operationBase; | |||
|
|
|||
| /// <summary> Initializes a new instance of ManagementGroupsCreateOrUpdateOperation for mocking. </summary> | |||
There was a problem hiding this comment.
Suggested change
| /// <summary> Initializes a new instance of ManagementGroupsCreateOrUpdateOperation for mocking. </summary> | |
| /// <summary> Initializes a new instance of ManagementGroupCreateOrUpdateOperationfor mocking. </summary> |
| { | ||
| } | ||
|
|
||
| internal ManagementGroupsCreateOrUpdateOperation(ResourceOperations operationsBase, ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, Request request, Response response) | ||
| internal ManagementGroupCreateOrUpdateOperation(ResourceOperations operationsBase, ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, Request request, Response response) | ||
| { | ||
| _operation = new OperationOrResponseInternals<ManagementGroup>(this, clientDiagnostics, pipeline, request, response, OperationFinalStateVia.AzureAsyncOperation, "ManagementGroupsCreateOrUpdateOperation"); |
There was a problem hiding this comment.
Suggested change
| _operation = new OperationOrResponseInternals<ManagementGroup>(this, clientDiagnostics, pipeline, request, response, OperationFinalStateVia.AzureAsyncOperation, "ManagementGroupsCreateOrUpdateOperation"); | |
| _operation = new OperationOrResponseInternals<ManagementGroup>(this, clientDiagnostics, pipeline, request, response, OperationFinalStateVia.AzureAsyncOperation, "ManagementGroupCreateOrUpdateOperation"); |
| @@ -18,16 +18,16 @@ namespace Azure.ResourceManager.Management.Models | |||
| /// If a management group contains child resources, the request will fail. | |||
| /// . | |||
| /// </summary> | |||
| public partial class ManagementGroupsDeleteOperation : Operation | |||
| public partial class ManagementGroupDeleteOperation : Operation | |||
| { | |||
| private readonly OperationOrResponseInternals _operation; | |||
|
|
|||
| /// <summary> Initializes a new instance of ManagementGroupsDeleteOperation for mocking. </summary> | |||
There was a problem hiding this comment.
Suggested change
| /// <summary> Initializes a new instance of ManagementGroupsDeleteOperation for mocking. </summary> | |
| /// <summary> Initializes a new instance of ManagementGroupDeleteOperation for mocking. </summary> |
| { | ||
| } | ||
|
|
||
| internal ManagementGroupsDeleteOperation(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, Request request, Response response) | ||
| internal ManagementGroupDeleteOperation(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline, Request request, Response response) | ||
| { | ||
| _operation = new OperationOrResponseInternals(clientDiagnostics, pipeline, request, response, OperationFinalStateVia.AzureAsyncOperation, "ManagementGroupsDeleteOperation"); |
There was a problem hiding this comment.
Suggested change
| _operation = new OperationOrResponseInternals(clientDiagnostics, pipeline, request, response, OperationFinalStateVia.AzureAsyncOperation, "ManagementGroupsDeleteOperation"); | |
| _operation = new OperationOrResponseInternals(clientDiagnostics, pipeline, request, response, OperationFinalStateVia.AzureAsyncOperation, "ManagementGroupDeleteOperation"); |
ShivangiReja
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.