Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vibankwa/azure.monitor.otel.exporter/fixbreakingtests #23063

Merged
merged 5 commits into from
Aug 3, 2021
Merged

Vibankwa/azure.monitor.otel.exporter/fixbreakingtests #23063

merged 5 commits into from
Aug 3, 2021

Conversation

vishweshbankwar
Copy link
Contributor

@vishweshbankwar vishweshbankwar commented Aug 3, 2021 •
edited
Loading

Fixing some tests which started failing on upgrading otel dependency to latest.

@vishweshbankwar vishweshbankwar marked this pull request as ready for review August 3, 2021 21:15
reyang
reyang approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TimothyMothra
TimothyMothra approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. review the test run and confirm that the tests actually ran.

@vishweshbankwar vishweshbankwar merged commit 4abd599 into main Aug 3, 2021
@vishweshbankwar vishweshbankwar deleted the vibankwa/Azure.Monitor.OTEL.Exporter/fixbreakingtests branch August 3, 2021 21:55
@vishweshbankwar vishweshbankwar added the Monitor - Exporter Monitor OpenTelemetry Exporter label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@TimothyMothra TimothyMothra TimothyMothra approved these changes

@reyang reyang reyang approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

Assignees
No one assigned
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vishweshbankwar @cijothomas @rajkumar-rangaraj @reyang @TimothyMothra