-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataFactory]Added new features into 4.16.0 #19811
Merged
Merged
+4,278
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jingshu923
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
March 25, 2021 01:55
markcowl
requested changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of customizations to prevent breaking changes, also, please update AzSDK.RP.Props with the new api-version
sdk/datafactory/Microsoft.Azure.Management.DataFactory/src/Generated/Models/FactoryIdentity.cs
Show resolved
Hide resolved
...icrosoft.Azure.Management.DataFactory/src/Generated/Models/AzureDataExplorerLinkedService.cs
Show resolved
Hide resolved
markcowl
requested changes
Mar 30, 2021
...tory/Microsoft.Azure.Management.DataFactory/src/Extensions/AzureDataExplorerLinkedService.cs
Outdated
Show resolved
Hide resolved
sdk/datafactory/Microsoft.Azure.Management.DataFactory/src/Extensions/FactoryIdentity.cs
Outdated
Show resolved
Hide resolved
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run net - mgmt - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
markcowl
approved these changes
Mar 30, 2021
/azp run net - mgmt - ci |
Commenter does not have sufficient privileges for PR 19811 in repo Azure/azure-sdk-for-net |
markcowl
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure/azure-rest-api-specs#13368
Updated AzureDataExplorer LinkedService servicePrincipalId, servicePrincipalKey, tenant properties from required to optional
Added accountKind property to AzureBlobStorage LinkedService
Azure/azure-rest-api-specs#13291
Azure/azure-rest-api-specs#13257
Added authHeaders to HTTP/REST/OData LinkedService
Added MultiFactor auth to SFTP LinkedService
Add authHeaders to HTTP/REST/OData Linked Service, add MultiFactor to SFTP authenticationType azure-rest-api-specs#13204
Added UAMI to Identity: [DataFactory] Add UAMI to Identity azure-rest-api-specs#13174
Added privateEndpointConnection apis to DataFactory: [DataFactory] Add privateEndpointConnection apis azure-rest-api-specs#13249
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
new service
label and/or contact assigned reviewer.Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,
Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.