Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataFactory]Added new features into 4.16.0 #19811

Merged
merged 7 commits into from
Mar 31, 2021
Merged

[DataFactory]Added new features into 4.16.0 #19811

merged 7 commits into from
Mar 31, 2021

Conversation

Jingshu923
Copy link
Contributor

  • Added Amazon S3 Compatible and Oracle Cloud Storage connectors

Azure/azure-rest-api-specs#13368

  • Updated AzureDataExplorer LinkedService servicePrincipalId, servicePrincipalKey, tenant properties from required to optional

  • Added accountKind property to AzureBlobStorage LinkedService

Azure/azure-rest-api-specs#13291

  • Added AAD auth to CosmosDb LinkedService

Azure/azure-rest-api-specs#13257

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Sorry, something went wrong.

@Jingshu923 Jingshu923 closed this Mar 25, 2021
@Jingshu923 Jingshu923 reopened this Mar 25, 2021
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of customizations to prevent breaking changes, also, please update AzSDK.RP.Props with the new api-version

@Jingshu923 Jingshu923 requested a review from markcowl March 26, 2021 08:07
@Jingshu923 Jingshu923 closed this Mar 30, 2021
@Jingshu923 Jingshu923 reopened this Mar 30, 2021
@markcowl
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@markcowl
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
merge
@shawnxzq
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 19811 in repo Azure/azure-sdk-for-net

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge
@markcowl markcowl merged commit 2e4f289 into Azure:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants