Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated storage agent pool #19191

Closed
wants to merge 1 commit into from

Conversation

mitchdenny
Copy link
Contributor

This PR cuts over the storage pipelines to use a dedicated storage pool that has been provisioned in Central Canada which has more memory for their specialized test scenarios.

@mitchdenny
Copy link
Contributor Author

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -5,23 +5,23 @@
},
"matrix": {
"Agent": {
"ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-general" },
"windows-2019": { "OSVmImage": "MMS2019", "Pool": "azsdk-pool-mms-win-2019-general" },
"ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-storage" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @benbp

@mitchdenny what strategy are you thinking about for overriding the pools we use here? Should we enable some way to override these values in the template instead of requiring that folks duplicate the entire matrix.json file?

Copy link
Member

@benbp benbp Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard when I was trying to show the pool override alternative to @mitchdenny , I found a small bug that made it not work :)

With the current import + override behavior (predicated on the above bug fix), this is what it could look like:

{
  "matrix": {
    "$IMPORT": "./eng/pipelines/templates/stages/platform-matrix.json",
    "PoolOverride": {
      "StorageLinuxPool": { "Pool": "azsdk-pool-mms-ubuntu-1804-storage" },
      "StorageWinPool": { "Pool": "azsdk-pool-mms-win-2019-storage" },
      "HostedMacPool": { "Pool": "Azure Pipelines" }
    }
  },
  "exclude": [
    {
      "Pool": "azsdk-pool-mms-ubuntu-1804-storage",
      "OSVmImage": [ "MMS2019", "MacOS-10.15" ]
    },
    {
      "Pool": "azsdk-pool-mms-win-2019-storage",
      "OSVmImage": [ "MMSUbuntu18.04", "MacOS-10.15" ]
    },
    {
      "Pool": "Azure Pipelines",
      "OSVmImage": [ "MMS2019", "MMSUbuntu18.04" ]
    }
  ]
}

It might be worth thinking about a replace type operator in the config for this kind of scenario.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the bug I mentioned: Azure/azure-sdk-tools#1461

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it might be interesting to have some sort of replace operator that could update the entire agent based on the name of the agent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me sketch something out.

@mitchdenny
Copy link
Contributor Author

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny enabled auto-merge (squash) March 8, 2021 23:04
@mitchdenny mitchdenny disabled auto-merge March 8, 2021 23:05
@mitchdenny mitchdenny enabled auto-merge (squash) March 8, 2021 23:06
@mitchdenny mitchdenny closed this Apr 12, 2021
auto-merge was automatically disabled April 12, 2021 04:51

Pull request was closed

@mitchdenny mitchdenny deleted the enable-storage-pool branch April 12, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants