[MetricsAdvisor] Added tests for the AnomalyDetectionConfiguration CRUD operations #17590
Conversation
kinelski
added
Client
| { | ||
| MetricsAdvisorAdministrationClient adminClient = GetMetricsAdvisorAdministrationClient(); | ||
|
|
||
| var config = new AnomalyDetectionConfiguration(FakeGuid, "configName", new ()); |
There was a problem hiding this comment.
just curious, is there any test that will verify the required input for AnomalyDetectionConfiguration?
There was a problem hiding this comment.
There isn't. However, we'll change some of our models' designs to have parameterless constructors (including AnomalyDetectionConfiguration), so these tests would be discarded. This is feedback we got during the archboard review (#16321).
There was a problem hiding this comment.
We'll still have models that may need validation after that, though. That's a good point, so just opened #17650 to track this. We can work on that after the design change.
kinelski
requested review from
kristapratico,
samvaity,
xiangyan99,
jeremymeng and
KarishmaGhiya
Just added others as reviewers in case they want to contribute. I'll keep it open for more time. |
Fixes #15915.
Tests ended up very large because we're testing a complex model. It takes multiple lines for setup and some more for validation.