[MetricsAdvisor] CreateDataFeed takes a whole DataFeed; DataSource property added to DataFeed #16366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
Client
kinelski
requested review from
christothes and
maririos
and removed request for
tg-msft and
KrzysztofCwalina
christothes
approved these changes
Oct 29, 2020
| /// <summary> | ||
| /// Initializes a new instance of a data source specific DataFeedDetail. | ||
| /// </summary> | ||
| internal DataFeedDetail InstantiateDataFeedDetail(string name, DataFeedGranularityType granularityType, IList<DataFeedMetric> metricColumns, DateTimeOffset ingestionStartTime) |
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
…operty added to DataFeed (Azure#16366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
DataSourceproperty toDataFeedmade some restructuring necessary. We are not keeping an internalDataFeedDetailinstance anymore. Instead, a newDataFeedDetailis built right before we serialize the model and send it to the service.These three possible scenarios are being covered:
DataFeedobject and callsCreateDataFeed.DataFeed.GetDataFeedDetailis called to build aDataFeedDetailfrom scratch. It goes as follows:DataFeedSource.InstantiateDataFeedDetailis made to get the rightDataFeedDetailderived class to build (AzureBlobDataFeed, for instance).DataFeed.DataFeedobject and callsUpdateDataFeed.DataFeed.GetPatchModelis called to build aDataFeedDetailPatchfrom scratch. It goes as follows:DataFeedSource.InstantiateDataFeedDetailPatchis made to get the rightDataFeedDetailPatchderived class to build (AzureBlobDataFeedPatch, for instance).DataFeed.GetDataFeedand a newDataFeedobject must be built fromDataFeedDetail. There are no major changes in the behavior, but we now need to be able to build aDataFeedSourcefrom theDataFeedDetailreturned by the service. The static methodDataFeedSource.GetDataFeedSourcewas created for this purpose.Fixes #16170.
Fixes #16313.