QnA Maker SDK 3.0.0-preview.1 #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somigithub
suggested changes
Oct 19, 2020
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/QnAMakerClient.cs
Outdated
Show resolved
Hide resolved
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/QnAMakerRuntimeClient.cs
Outdated
Show resolved
Hide resolved
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/Runtime.cs
Outdated
Show resolved
Hide resolved
somigithub
suggested changes
Oct 20, 2020
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/Runtime.cs
Outdated
Show resolved
Hide resolved
sdk/cognitiveservices/Knowledge.QnAMaker/tests/QnAMakerAlterationsTests.cs
Outdated
Show resolved
Hide resolved
somigithub
approved these changes
Oct 20, 2020
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/Runtime.cs
Outdated
Show resolved
Hide resolved
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/QnAMakerClient.cs
Show resolved
Hide resolved
sdk/cognitiveservices/Knowledge.QnAMaker/src/Customizations/Runtime.cs
Outdated
Show resolved
Hide resolved
...eservices/Knowledge.QnAMaker/src/Microsoft.Azure.CognitiveServices.Knowledge.QnAMaker.csproj
Show resolved
Hide resolved
AlexGhiondea
suggested changes
Oct 20, 2020
AlexGhiondea
approved these changes
Oct 20, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* SDK for V5.0-preview.1 * change version to 3.0.0-preview.1 * Avoid boolean parameter, endpointsettings test * session record updated * testcase file and name corrected, PR comments addressed, made custom constructor internal * comment updated, csproj version to check appcompat errors * Remove AppCompatVersion as this would be major version upgrade * Dispose method removed. * ## 3.0.0-preview.1 (2020-10-20) * Address PR comments and Simplify tests, skip one until service fix * Addressed PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QnA Maker SDK 3.0.0-preview.1
with support for new features in V5.0-preview.1 API and custom client for V4 runtime