Azure Monitor Exporter - Add IngestionResponsePolicy #16032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkumar-rangaraj
requested review from
cijothomas,
reyang and
TimothyMothra
as code owners
rajkumar-rangaraj
changed the title
reyang
reviewed
Oct 16, 2020
sdk/monitor/OpenTelemetry.Exporter.AzureMonitor/src/ApplicationInsightsRestClient.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Oct 16, 2020
| } | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| if (ex?.InnerException?.InnerException?.Source == "System.Net.Http") |
reyang
reviewed
Oct 16, 2020
sdk/monitor/OpenTelemetry.Exporter.AzureMonitor/src/IngestionResponsePolicy.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Oct 16, 2020
sdk/monitor/OpenTelemetry.Exporter.AzureMonitor/src/ResponseStatusCodes.cs
Outdated
Show resolved
Hide resolved
sdk/monitor/OpenTelemetry.Exporter.AzureMonitor/src/IngestionResponsePolicy.cs
Show resolved
Hide resolved
sdk/monitor/OpenTelemetry.Exporter.AzureMonitor/src/ApplicationInsightsRestClient.cs
Show resolved
Hide resolved
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* Added IngestionResponsePolicy * check for object is int * Added constant to response code * Added method summary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retryprovided with Azure SDKIngestionResponsePolicywhich inherits fromHttpPipelineSynchronousPolicy. This policy will have ability to check parse response and store to diskApplicationInsightsRestClientto returnItemsAcceptedonInternalTrackAsyncInternalTrackAsyncoverload to send data from storage