-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add System.Text.Json support for Microsoft.Spatial #15468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
requested review from
arv100kri,
bleroy,
KrzysztofCwalina and
mitchdenny
as code owners
September 25, 2020 21:25
pakrym
reviewed
Sep 25, 2020
sdk/core/Microsoft.Azure.Core.Spatial/src/Serialization/GeographyPointConverter.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Sep 25, 2020
sdk/core/Microsoft.Azure.Core.Spatial/tests/Serialization/GeographyPointConverterTests.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Sep 25, 2020
sdk/core/Microsoft.Azure.Core.Spatial/src/Serialization/GeographyPointConverter.cs
Outdated
Show resolved
Hide resolved
heaths
requested review from
chidozieononiwu,
danieljurek and
weshaggard
as code owners
September 25, 2020 23:20
5 tasks
/azp run net - core - ci |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run net - search - ci |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
pakrym
reviewed
Sep 29, 2020
sdk/core/Microsoft.Azure.Core.Spatial/src/Microsoft.Azure.Core.Spatial.csproj
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Sep 29, 2020
sdk/core/Microsoft.Azure.Core.Spatial/src/Serialization/GeographyConverter.cs
Outdated
Show resolved
Hide resolved
pakrym
approved these changes
Sep 29, 2020
tg-msft
approved these changes
Sep 29, 2020
weshaggard
reviewed
Sep 29, 2020
sdk/core/Microsoft.Azure.Core.Spatial/src/Microsoft.Azure.Core.Spatial.props
Show resolved
Hide resolved
/azp run net - core |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
@heaths currently we can only trigger pipelines that match the branch naming conventions in our branching guidelines. So if you want to trigger you should update your base branch. |
heaths
requested review from
pakrym and
KrzysztofCwalina
and removed request for
chidozieononiwu,
bikamani,
seanmcc-msft,
ShivangiReja,
amnguye,
bquantump,
JoshLove-msft,
kasobol-msft,
m-nash and
nisha-bhatia
September 30, 2020 00:21
pakrym
reviewed
Sep 30, 2020
sdk/core/Microsoft.Azure.Core.Spatial/tests/Microsoft.Azure.Core.Spatial.Tests.csproj
Outdated
Show resolved
Hide resolved
pakrym
approved these changes
Sep 30, 2020
Setting up for Azure#15506
Resolves Azure#15431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15431