Dns ZoneType Change #15236
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| // <auto-generated/> | ||
|
|
||
| #nullable disable | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using Azure.Core; | ||
|
|
||
| namespace Azure.ResourceManager.Dns.Models | ||
| { | ||
| /// <summary> Describes a DNS zone. </summary> | ||
| public partial class Zone : Resource | ||
| { | ||
| /// <summary> Initializes a new instance of Zone. </summary> | ||
| /// <param name="location"> Resource location. </param> | ||
| /// <exception cref="ArgumentNullException"> <paramref name="location"/> is null. </exception> | ||
| public Zone(string location) : base(location) | ||
| { | ||
| if (location == null) | ||
| { | ||
| throw new ArgumentNullException(nameof(location)); | ||
| } | ||
|
|
||
| NameServers = new ChangeTrackingList<string>(); | ||
| RegistrationVirtualNetworks = new ChangeTrackingList<SubResource>(); | ||
| ResolutionVirtualNetworks = new ChangeTrackingList<SubResource>(); | ||
| } | ||
|
|
||
| /// <summary> Initializes a new instance of Zone. </summary> | ||
| /// <param name="id"> Resource ID. </param> | ||
| /// <param name="name"> Resource name. </param> | ||
| /// <param name="type"> Resource type. </param> | ||
| /// <param name="location"> Resource location. </param> | ||
| /// <param name="tags"> Resource tags. </param> | ||
| /// <param name="etag"> The etag of the zone. </param> | ||
| /// <param name="maxNumberOfRecordSets"> The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored. </param> | ||
| /// <param name="numberOfRecordSets"> The current number of record sets in this DNS zone. This is a read-only property and any attempt to set this value will be ignored. </param> | ||
| /// <param name="nameServers"> The name servers for this DNS zone. This is a read-only property and any attempt to set this value will be ignored. </param> | ||
| /// <param name="zoneType"> The type of this DNS zone (Public or Private). </param> | ||
| /// <param name="registrationVirtualNetworks"> A list of references to virtual networks that register hostnames in this DNS zone. This is a only when ZoneType is Private. </param> | ||
| /// <param name="resolutionVirtualNetworks"> A list of references to virtual networks that resolve records in this DNS zone. This is a only when ZoneType is Private. </param> | ||
| internal Zone(string id, string name, string type, string location, IDictionary<string, string> tags, string etag, long? maxNumberOfRecordSets, long? numberOfRecordSets, IReadOnlyList<string> nameServers, ZoneType? zoneType, IList<SubResource> registrationVirtualNetworks, IList<SubResource> resolutionVirtualNetworks) : base(id, name, type, location, tags) | ||
allenjzhang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| Etag = etag; | ||
| MaxNumberOfRecordSets = maxNumberOfRecordSets; | ||
| NumberOfRecordSets = numberOfRecordSets; | ||
| NameServers = nameServers; | ||
| ZoneType = zoneType; | ||
| RegistrationVirtualNetworks = registrationVirtualNetworks; | ||
| ResolutionVirtualNetworks = resolutionVirtualNetworks; | ||
| } | ||
|
|
||
| /// <summary> The etag of the zone. </summary> | ||
| public string Etag { get; set; } | ||
| /// <summary> The maximum number of record sets that can be created in this DNS zone. This is a read-only property and any attempt to set this value will be ignored. </summary> | ||
| public long? MaxNumberOfRecordSets { get; } | ||
| /// <summary> The current number of record sets in this DNS zone. This is a read-only property and any attempt to set this value will be ignored. </summary> | ||
| public long? NumberOfRecordSets { get; } | ||
| /// <summary> The name servers for this DNS zone. This is a read-only property and any attempt to set this value will be ignored. </summary> | ||
| public IReadOnlyList<string> NameServers { get; } | ||
| /// <summary> The type of this DNS zone (Public or Private). </summary> | ||
| [Obsolete("Private DNS is not allowed in this API anymore, use the privatedns API")] | ||
| public ZoneType? ZoneType { get; } | ||
| /// <summary> A list of references to virtual networks that register hostnames in this DNS zone. This is a only when ZoneType is Private. </summary> | ||
| [Obsolete("Private DNS is not allowed in this API anymore, use the privatedns API")] | ||
| public IList<SubResource> RegistrationVirtualNetworks { get; } | ||
|
There was a problem hiding this comment. Do we need [Obsolete] on these two properties? There was a problem hiding this comment. hmm actually do want to do this? Since a user could want to view these and they would get a compile error trying to get these unless that suppress that warning? There was a problem hiding this comment. they are only read-only, so they would only come back from a GET on a private DNS zone There was a problem hiding this comment. I think [Obsolete] can be applied here. If user is using these properties, they will get a compiler warning which is what we wanted. There was a problem hiding this comment. Well depends on how one builds I suppose. Dotnet core on Ubuntu throws a compile error. I will make this change. |
||
| /// <summary> A list of references to virtual networks that resolve records in this DNS zone. This is a only when ZoneType is Private. </summary> | ||
| [Obsolete("Private DNS is not allowed in this API anymore, use the privatedns API")] | ||
| public IList<SubResource> ResolutionVirtualNetworks { get; } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend not copying all the members, just ones you need to add attributes to.