Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remnants of dotnet core versions #14783

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Remove remnants of dotnet core versions #14783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions common/SmokeTests/smoke-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,6 @@ jobs:
steps:
- template: /eng/common/pipelines/templates/steps/verify-agent-os.yml

- task: UseDotNet@2
displayName: "Use .NET Core runtime $(DotNetCoreRuntimeVersion)"
inputs:
packageType: runtime
version: "$(DotNetCoreRuntimeVersion)"

- task: UseDotNet@2
displayName: "Use .NET Core sdk $(DotNetCoreSDKVersion)"
inputs:
packageType: sdk
version: "$(DotNetCoreSDKVersion)"

- task: PowerShell@2
inputs:
targetType: filePath
Expand Down
2 changes: 0 additions & 2 deletions eng/pipelines/templates/variables/globals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
variables:
DocWardenVersion: '0.6.1'
DotNetCoreSDKVersion: '3.1.301'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these? The agent configuration will change. These make sure we get the same baseline as we want to support for our customers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its now specified in the global.json

Copy link
Member

@heaths heaths Sep 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That just requires it. Something has to install it, which is what those tasks do if it's not already installed (also adds it to PATH).

Copy link
Member Author

@chidozieononiwu chidozieononiwu Sep 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already installed on the build agents. so Installing it again is quite redundant. Also we will know in the event a build agent does not have it because the build will just fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to their documentation, it shouldn't acquire a version if already installed; however, I can find nothing in their source that supports that claim.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the reason we have made this change is to avoid it downloading and installing the sdk every time as that step fails from time to time which we want to try and eliminate. See #12120 for some of that conversation.

DotNetCoreRuntimeVersion: '2.1.10'
OfficialBuildId: $(Build.BuildNumber)
ConvertToProjectReferenceOption: ''
skipComponentGovernanceDetection: true
Expand Down