Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TA] Make TextAnalyticsError and TextAnalyticsWarning immutable #14556

Merged
merged 2 commits into from
Aug 28, 2020
Merged

[TA] Make TextAnalyticsError and TextAnalyticsWarning immutable #14556

merged 2 commits into from
Aug 28, 2020

Conversation

maririos
Copy link
Member

Fixes: #14549

@maririos maririos added Client This issue points to a problem in the data-plane of the library. APIChange Cognitive - Text Analytics labels Aug 25, 2020
kinelski
kinelski approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@kinelski kinelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maririos maririos merged commit 8217fe9 into Azure:master Aug 28, 2020
@weshaggard weshaggard mentioned this pull request Sep 18, 2020
Merged
@maririos maririos deleted the readonly branch February 8, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinelski kinelski kinelski approved these changes

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@pakrym pakrym Awaiting requested review from pakrym

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TextAnalyticsError and TextAnalyticsWarning readonly
2 participants
@maririos @kinelski