Default to ResponseFormat.ReturnNoContent on AddEntity #14462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
KrzysztofCwalina,
pakrym and
tg-msft
as code owners
ghost
added
the
ellismg
approved these changes
Aug 21, 2020
| @@ -14,14 +14,14 @@ public TablesTestEnvironment() : base("tables") | |||
| // Storage Tables | |||
| public const string PrimaryStorageKeyEnvironmentVariableName = "TABLES_PRIMARY_STORAGE_ACCOUNT_KEY"; | |||
| private const string StorageUriFormat = "https://{0}.table.core.windows.net"; | |||
| public string PrimaryStorageAccountKey => GetRecordedVariable(PrimaryStorageKeyEnvironmentVariableName, options => options.IsSecret()); | |||
| public string PrimaryStorageAccountKey => GetRecordedVariable(PrimaryStorageKeyEnvironmentVariableName, options => options.IsSecret(SanitizedValue.Base64)); | |||
There was a problem hiding this comment.
So I can learn more about this stuff, do you mind telling me why this change was made?
There was a problem hiding this comment.
Ah - this was a recent feature change to how sanitized values are configured for recording tests. So when I re-recorded I changed to the new pattern which allows this storage key value to be "sanitized" to a safe value. The SanitizedValue.Base64 enum indicates to transform this string value into a bare minimum base64 string value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14459