[Management Plane][Azure Cognitive Search] Update SDK code for the new API version #14059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Once the swagger PR is checked in, need to regenerate from master branch to update the metadata |
10 tasks
arv100kri
requested review from
allenjzhang,
bleroy and
markcowl
as code owners
This is now done |
added 14 commits
August 27, 2020 10:01
arv100kri
force-pushed
the
arv100kri/new-sdk
branch
from
e5c9274 to
6d76dc8
Compare
tjacobhi
reviewed
Aug 27, 2020
| @@ -46,7 +46,7 @@ public void CanListServicesBySubscription() | |||
|
|
|||
| var services = searchMgmt.Services.ListBySubscription(); | |||
| Assert.NotNull(services); | |||
| Assert.Equal(2, services.Count()); | |||
| Assert.Equal(2, services.Where(service => service.Name.StartsWith("azs-")).Count()); | |||
There was a problem hiding this comment.
This is a great addition, thanks for this!
tjacobhi
approved these changes
Aug 27, 2020
timothyta12
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up from the REST API specs PR: Azure/azure-rest-api-specs#10255 and generates a new SDK pointing to the GA API version 2020-08-01.
Key features:
SearchServiceUpdatemodel represents the data required to update an existing search service.