Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new Resource Public maintenance configurations and GET/LISTAPI #13873

Merged
merged 4 commits into from
Aug 6, 2020
Merged

Adding new Resource Public maintenance configurations and GET/LISTAPI #13873

merged 4 commits into from
Aug 6, 2020

Conversation

sotaneja
Copy link
Contributor

@isra-fel
Copy link
Member

@allenjzhang could you take this one? Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Jul 31, 2020
isra-fel
isra-fel suggested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write tests for the new resource type. Thanks

sdk/maintenance/Microsoft.Azure.Management.Maintenance/tests/Properties/AssemblyInfo.cs Show resolved Hide resolved
@sotaneja sotaneja removed their assignment Aug 6, 2020
isra-fel
isra-fel approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 9fe88a6 into Azure:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@allenjzhang allenjzhang

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotaneja @isra-fel @allenjzhang