-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Autorest C# - eventhub #13585
Conversation
@@ -28,7 +28,7 @@ public async Task ConsumerGroupsCreateGetUpdateDelete() | |||
{ | |||
Tier = SkuTier.Standard, | |||
}, | |||
Tags = new Dictionary<string, string>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pakrym , when running this code, NullReferenceException is throw after removing new Dictionary<string, string>()
here. It seems that Tags
is not initialized with new Dictionary<>
in TrackedResource.cs, could you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure the exception happens on this line?
Tags collection is initialized in ctor https://github.com/Azure/azure-sdk-for-net/pull/13585/files#diff-ee5ab4c1618b272e8775ca1a33b97a56R19
Update Eventhub test record
Update eventhub test record to fix api version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributes to #13511
Major features
x-ms-client-name
honored.modelAsString
enums are generated as types, they were string constants before.What you might need to do: