Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for CDN API version 2020-04-15. #13446

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Update for CDN API version 2020-04-15. #13446

merged 3 commits into from
Jul 22, 2020

Conversation

fore5fire
Copy link
Contributor

No description provided.

@fore5fire fore5fire force-pushed the cdn/2020-04-15 branch 2 times, most recently from 79b7dc3 to b28928d Compare July 14, 2020 22:51
@isra-fel
Copy link
Member

Hi @lsmith130 , could you

  • Add a link to the openapi spec review PR here
  • Update api tag in AzSdk.RP.props, release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@fore5fire
Copy link
Contributor Author

@isra-fel, Thanks for the feedback. I've updated made the requested updates, along with regenerating the SDK to include a few bug fixes. The relevant openapi spec review PRs can be found here: Azure/azure-rest-api-specs#9242, Azure/azure-rest-api-specs#9433, Azure/azure-rest-api-specs#9858, Azure/azure-rest-api-specs#9997, Azure/azure-rest-api-specs#10126, Azure/azure-rest-api-specs#10141

@isra-fel
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

isra-fel
isra-fel approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel self-assigned this Jul 22, 2020
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. Waiting for CI :shipit: labels Jul 22, 2020
@isra-fel isra-fel merged commit 8a33fd4 into Azure:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fore5fire @isra-fel