Search: Make SuggestResults.Results read only #13003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tg-msft
requested review from
arv100kri,
bleroy,
brjohnstmsft,
heaths,
KrzysztofCwalina and
pakrym
as code owners
heaths
approved these changes
Jun 25, 2020
| /// <summary> | ||
| /// The sequence of suggestions returned by the query. | ||
| /// </summary> | ||
| public IReadOnlyList<SearchSuggestion<T>> Results => _results; |
There was a problem hiding this comment.
Nit: this would still be castable to a mutable list, but I know we've done it this way elsewhere. Perhaps, though, you might consider wrapping _results in a ReadOnlyCollection that prevents this.
There was a problem hiding this comment.
It touches slightly more code, but it's a fair suggestion.
prmathur-microsoft
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Search: Make SuggestResults.Results read only Fixes #12936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12936 to be in compliance with the guidelines