Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synapse] - Add Support for private link and fix node count issue for Spark pool #12709

Merged

Conversation

idear1203
Copy link
Contributor

Generate C# SDK code based on the latest Swagger specs. This change does the following things:

  1. Support private link feature
  2. Remove node count constraint for big data pool info (In some scenarios, it causes undesired failure.)

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Jun 11, 2020
@isra-fel isra-fel self-assigned this Jun 11, 2020
@idear1203 idear1203 changed the title Add Support for private link and fix node count issue for Spark pool [Synapse] - Add Support for private link and fix node count issue for Spark pool Jun 16, 2020
@@ -7,14 +7,12 @@
<PackageId>Microsoft.Azure.Management.Synapse</PackageId>
<Description>Azure Synapse Management SDK Library</Description>
<AssemblyName>Microsoft.Azure.Management.Synapse</AssemblyName>
<Version>0.1.0-preview.2</Version>
<Version>0.1.0-preview.3</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have pointed this out earlier, but our versioning guide suggests the first version should be 1.0.0-preview.1.
Since Synapse hasn't GAed I believe it's still ok to make the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. I changed the version to 1.0.0-preview.1.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isra-fel isra-fel merged commit 3d487ed into Azure:master Jun 16, 2020
prmathur-microsoft pushed a commit that referenced this pull request Jul 8, 2020
… Spark pool (#12709)

* Add Support for private link and fix node count issue for Spark pool

* Update package version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants