Reference source code of test helper projects for KeyVault test project #12498
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <RbacSharedSources>$(MSBuildThisFileDirectory)/../sdk/testcommon/Azure.Graph.Rbac/src</RbacSharedSources> | ||
| <Resources201705SharedSources>$(MSBuildThisFileDirectory)/../sdk/testcommon/Azure.Management.Resources.2017_05/src</Resources201705SharedSources> | ||
| <Compute201912SharedSources>$(MSBuildThisFileDirectory)/../sdk/testcommon/Azure.Management.Compute.2019_12/src</Compute201912SharedSources> | ||
| <Network202004SharedSources>$(MSBuildThisFileDirectory)/../sdk/testcommon/Azure.Management.Network.2020_04/src</Network202004SharedSources> | ||
| <Storage201906SharedSources>$(MSBuildThisFileDirectory)/../sdk/testcommon/Azure.Management.Storage.2019_06/src</Storage201906SharedSources> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Condition="$(TestHelperProjects.Contains('Rbac1.6'))"> | ||
| <Compile Include="$(RbacSharedSources)/**/*.cs" | ||
| Link="Rbac/%(RecursiveDir)%(Filename)%(Extension)" | ||
| Exclude="$(RbacSharedSources)/Properties/AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$(TestHelperProjects.Contains('Resources201705'))"> | ||
| <Compile Include="$(Resources201705SharedSources)/**/*.cs" | ||
| Link="Resources201705/%(RecursiveDir)%(Filename)%(Extension)" | ||
| Exclude="$(Resources201705SharedSources)/Properties/AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$(TestHelperProjects.Contains('Compute201912'))"> | ||
| <Compile Include="$(Compute201912SharedSources)/**/*.cs" | ||
| Link="Compute201912/%(RecursiveDir)%(Filename)%(Extension)" | ||
| Exclude="$(Compute201912SharedSources)/Properties/AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$(TestHelperProjects.Contains('Network202004'))"> | ||
| <Compile Include="$(Network202004SharedSources)/**/*.cs" | ||
| Link="Network202004/%(RecursiveDir)%(Filename)%(Extension)" | ||
| Exclude="$(Network202004SharedSources)/Properties/AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$(TestHelperProjects.Contains('Storage201906'))"> | ||
| <Compile Include="$(Storage201906SharedSources)/**/*.cs" | ||
| Link="Storage201906/%(RecursiveDir)%(Filename)%(Extension)" | ||
| Exclude="$(Storage201906SharedSources)/Properties/AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
|
Comment on lines
+10
to
+38
There was a problem hiding this comment. It's a good solution, but is this going to scale as you add more management sources? Or is this only temporary? |
||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TestHelperProjects>Rbac1.6;Resources201705;</TestHelperProjects> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\src\Azure.Management.KeyVault.csproj" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| [assembly: Azure.Core.AzureResourceProviderNamespace("Microsoft.KeyVault")] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is your plan to still move these under "common"? Also we still need to rename at least the Azure.Graph.Rbac directory has it is causes issue because it looks like a track2 library but it isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets please file a tracking issue to move this after the preview work is out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use #12209 to track the request.