Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from master #12243

Closed
wants to merge 1 commit into from
Closed

Update from master #12243

wants to merge 1 commit into from

Conversation

fore5fire
Copy link
Contributor

Updating CDN SDK for version 2020-04-15

@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAutomation/Microsoft.Azure.Management.Cdn branch from 57c0298 to 2213b5b Compare May 22, 2020 22:11
isra-fel
isra-fel reviewed May 25, 2020
View reviewed changes
sdk/cdn/Microsoft.Azure.Management.Cdn/src/Generated/CdnManagementClient.cs
/// <summary>
/// Azure Subscription ID.
/// </summary>
public string SubscriptionId1 { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's definitely something wrong here. Please make sure the SDK is generated by running generate.ps1 and your build tools are up to date.

Besides, please point to me the link to your openapi spec review PR. Thanks

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. Missing Spec PR link labels May 25, 2020
@openapi-sdkautomation openapi-sdkautomation bot force-pushed the sdkAutomation/Microsoft.Azure.Management.Cdn branch from 2213b5b to 1390f7f Compare May 26, 2020 21:04
@isra-fel
Copy link
Member

Hi @lsmith130 I just noticed this PR was created from a SDK automation branch. Please never do that, because that branch changes often whenever there's change to openapi spec (as you can see it's force-pushed just now).
Please follow our guideline to generate manually: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#generating-net-sdk
Thanks

@isra-fel isra-fel closed this May 27, 2020
@fore5fire
Copy link
Contributor Author

fore5fire commented May 27, 2020 •
edited
Loading

@isra-fel, thanks for the info. It might be a good idea to remove the message from the swagger PR that says to open a PR from the automation and provides a link to do so. For example the automated comment in my azure-rest-api-specs PR has a link that says "Release SDK Changes" when you expand it: Azure/azure-rest-api-specs#9433 (comment)

@isra-fel
Copy link
Member

isra-fel commented Jun 1, 2020

@isra-fel, thanks for the info. It might be a good idea to remove the message from the swagger PR that says to open a PR from the automation and provides a link to do so. For example the automated comment in my azure-rest-api-specs PR has a link that says "Release SDK Changes" when you expand it: Azure/azure-rest-api-specs#9433 (comment)

Sounds reasonable to me. @NullMDR hello Phoenix, can we update the Release SDK Change label just for .NET SDK? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel left review comments

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@fore5fire fore5fire

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fore5fire @isra-fel