Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Peering SDK to 2020-04-01 API version #12018

Merged
merged 8 commits into from
May 14, 2020
Merged

Update Peering SDK to 2020-04-01 API version #12018

merged 8 commits into from
May 14, 2020

Conversation

psanapathi
Copy link
Member

No description provided.

@isra-fel
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels May 13, 2020
@isra-fel isra-fel self-assigned this May 13, 2020
isra-fel
isra-fel suggested changes May 13, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @psanapathi

  • Please add a link to the openapi spec review PR here
  • peering_resource-manager.txt is in old format, please update your build tools and make sure the SDK is generated by running src/generate.ps1
  • Update api tag in AzSdk.RP.props, release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@psanapathi
Copy link
Member Author

Hello @psanapathi

  • Please add a link to the openapi spec review PR here
  • peering_resource-manager.txt is in old format, please update your build tools and make sure the SDK is generated by running src/generate.ps1
  • Update api tag in AzSdk.RP.props, release notes in csproj
  • Update versions in csproj and assemblyinfo.cs if you are going to release

Thanks

@psanapathi psanapathi requested a review from isra-fel May 13, 2020 22:39
@psanapathi psanapathi requested a review from isra-fel May 14, 2020 01:57
isra-fel
isra-fel approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel isra-fel merged commit dcdbbfa into Azure:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psanapathi @isra-fel