Arg validation clean up #11893
Merged
Arg validation clean up #11893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLove-msft
requested review from
jsquire,
nemakam and
ShivangiReja
as code owners
JoshLove-msft
commented
May 7, 2020
| @@ -79,7 +77,7 @@ public TimeSpan MaxAutoLockRenewalDuration | |||
| { | |||
| if (value.HasValue) | |||
| { | |||
| TimeoutHelper.ThrowIfNegativeArgument(value.Value, nameof(MaxReceiveWaitTime)); | |||
| Argument.AssertPositive(value.Value, nameof(MaxReceiveWaitTime)); | |||
There was a problem hiding this comment.
This should actually be positive rather than just non-negative.
There was a problem hiding this comment.
I assume the result of Argument.AssertNotNegative and Argument.AssertPositive will be the same, both will throw for negative value? if yes, then why do have 2 different methods?
There was a problem hiding this comment.
AssertNotNegative allows >= 0
AssertPositive allows > 0
ShivangiReja
approved these changes
May 8, 2020
| @@ -79,7 +77,7 @@ public TimeSpan MaxAutoLockRenewalDuration | |||
| { | |||
| if (value.HasValue) | |||
| { | |||
| TimeoutHelper.ThrowIfNegativeArgument(value.Value, nameof(MaxReceiveWaitTime)); | |||
| Argument.AssertPositive(value.Value, nameof(MaxReceiveWaitTime)); | |||
There was a problem hiding this comment.
I assume the result of Argument.AssertNotNegative and Argument.AssertPositive will be the same, both will throw for negative value? if yes, then why do have 2 different methods?
|
@JoshLove-msft PR looks good to me. Thanks for cleaning this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of using the Track 1 Fx/ExceptionUtilities in favor of using Azure Core Argument methods. Also deleted a few other unused files.