Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining methods to SearchServiceClient #11049

Merged
merged 4 commits into from
Apr 6, 2020

Conversation

heaths
Copy link
Member

@heaths heaths commented Apr 4, 2020

An initial look at the API changes. I'll add a recorded hero test or two in another commit to add to this PR, but wanted to get the brunt of the impactful work ready for review.

@heaths heaths added Search Do Not Merge Client This issue points to a problem in the data-plane of the library. labels Apr 4, 2020
@heaths heaths requested a review from tg-msft April 4, 2020 00:30
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

More tests will be added for preview 3, but these tests exercise a decent amount of the new SearchServiceClient APIs in a plausible use case.
@heaths heaths force-pushed the search-service-client branch from cca6289 to aa95321 Compare April 6, 2020 05:45
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - left a few comments on the test infrastructure changes, but they don't need to be addressed as part of this PR.

@tg-msft
Copy link
Member

tg-msft commented Apr 6, 2020

/azp run net - search - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths heaths merged commit bc4983f into Azure:master Apr 6, 2020
@heaths heaths deleted the search-service-client branch April 6, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants