-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining methods to SearchServiceClient #11049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
More tests will be added for preview 3, but these tests exercise a decent amount of the new SearchServiceClient APIs in a plausible use case.
cca6289
to
aa95321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - left a few comments on the test infrastructure changes, but they don't need to be addressed as part of this PR.
/azp run net - search - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
An initial look at the API changes. I'll add a recorded hero test or two in another commit to add to this PR, but wanted to get the brunt of the impactful work ready for review.