Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] SharedAccessSignatureProvider.tokenTimeToLive default throws opaque exception #6312

Closed
jasonholloway opened this issue May 17, 2019 · 4 comments · Fixed by #7053
Closed

[BUG] SharedAccessSignatureProvider.tokenTimeToLive default throws opaque exception #6312

jasonholloway opened this issue May 17, 2019 · 4 comments · Fixed by #7053
Assignees
@nemakam
Labels
Authorization customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. Service Bus

Comments

@jasonholloway
Copy link

When using the ASB client to publish to a topic:

The SharedAccessSignatureProvider.tokenTimeToLive field, if left at its default value (as is incredibly simple to do when configuring via MassTransit), causes an obscure exception to be thrown by the framework Timer class on first received message - this is because of a lack of validation in the Microsoft code, leading to negative numbers in the wrong places.

ActiveClientLinkManager is the place to look for the offending code, and the best explanation can be found attached to the end of this closed issue in the archived repo: Azure/azure-service-bus-dotnet#399 (comment)

This is likely to be affecting a large proportion of people using Azure Service Bus via MassTransit - sensible default behaviour is needed!
@triage-new-issues triage-new-issues bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 17, 2019
@kurtzeborn kurtzeborn added Authorization Mgmt This issue is related to a management-plane library. labels May 20, 2019
@triage-new-issues triage-new-issues bot removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 20, 2019
@kurtzeborn kurtzeborn added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 20, 2019
@kurtzeborn
Copy link
Member

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

CC: @shahabhijeet

@AlexGhiondea AlexGhiondea added Service Bus Service Attention Workflow: This issue is responsible by Azure service team. labels Jul 30, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl

@AlexGhiondea
Copy link
Contributor

/cc @binzywu

@jfggdl
Copy link

jfggdl commented Jul 30, 2019

@jasonholloway, Thank you. We are already looking at the suggested approach in the link provided.

@nemakam nemakam mentioned this issue Jul 30, 2019
Merged
nemakam added a commit that referenced this issue Jul 31, 2019
@nemakam
Ensure if link has been authorized for a time less than TokenRefreshB…
ac885a7 
…uffer, it doesn't lead to unexpected errors. (#7053)

Ensure if link has been authorized for a time less than TokenRefreshBuffer, it doesn't lead to unexpected errors.

Fixes #6312
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nemakam nemakam

Labels
Authorization customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. Service Bus
Projects
None yet
Milestone
No milestone
5 participants
@jasonholloway @jfggdl @AlexGhiondea @kurtzeborn @nemakam