Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Improve the build script for typesepc/cadl projects #34357

Closed
ArcturusZhang opened this issue Feb 18, 2023 · 0 comments · Fixed by Azure/autorest.csharp#3166 or Azure/azure-sdk-tools#5540
Closed

[FEATURE REQ] Improve the build script for typesepc/cadl projects #34357

ArcturusZhang opened this issue Feb 18, 2023 · 0 comments · Fixed by Azure/autorest.csharp#3166 or Azure/azure-sdk-tools#5540
Assignees
@chunyu3
Labels
Client This issue points to a problem in the data-plane of the library. DPG EngSys This issue is impacting the engineering system.

Comments

@ArcturusZhang
Copy link
Member

Library name

build scripts

Please describe the feature.

In our current build scripts, running dotnet build /t:GenerateCode command in the typespec/cadl projects will invoke our emitter (here) and the emitter then invokes the generator Autorest.CSharp.dll (here), which might not be the issue. The issue is that this invocation chain is not picking up the version of Autorest.CSharp.dll honoring the version inside Package.Data.props and making things very complicated when we want to regenerate the SDK using a local generator version for those typespec/cadl projects.
We need to improve either the script so that we could easily set the version of the path to the generator, or let the emitter honor the version inside Package.Data.props
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 18, 2023
@ArcturusZhang ArcturusZhang added EngSys This issue is impacting the engineering system. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 18, 2023
@ArcturusZhang ArcturusZhang mentioned this issue Feb 18, 2023
Merged
6 tasks
@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label Feb 18, 2023
This was referenced Feb 22, 2023
Closed
Merged
Merged
@lirenhe lirenhe added the DPG label Feb 27, 2023
ghost pushed a commit to Azure/azure-sdk-tools that referenced this issue Mar 1, 2023
@chunyu3
add parameter to set cadl emitter options (#5540)
534a5c7 
Fix Azure/azure-sdk-for-net#34357

- Add parameter to set cadl emitter options
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chunyu3 chunyu3

Labels
Client This issue points to a problem in the data-plane of the library. DPG EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
4 participants
@jsquire @lirenhe @chunyu3 @ArcturusZhang