Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move required TFMs to net7.0, net6.0 #32596

Closed
3 tasks done
heaths opened this issue Nov 22, 2022 · 4 comments · Fixed by #32814
Closed
3 tasks done

Move required TFMs to net7.0, net6.0 #32596

heaths opened this issue Nov 22, 2022 · 4 comments · Fixed by #32814
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Milestone
2023-02

Comments

@heaths
Copy link
Member

heaths commented Nov 22, 2022 •
edited
Loading

With netcoreapp3.1 falling out of support soon, move to the latest version - net7.0 - and the latest LTS - net6.0.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative. labels Nov 22, 2022
@heaths heaths added this to the 2022-12 milestone Nov 22, 2022
@heaths heaths self-assigned this Nov 22, 2022
@heaths
Copy link
Member Author

heaths commented Nov 22, 2022

@KrzysztofCwalina @tg-msft @pallavit @jsquire should we alert partners before or after we make this change. This also means updating global.json to require it. I can also add a .vsconfig to have VS suggest installing both net7.0 and net6.0 targeting packs if not installed.

@jsquire
Copy link
Member

jsquire commented Nov 22, 2022

I believe we'd want to update the Contributing guide and also alert partners. It may be good to give them a short (week?) heads-up so that we don't just start randomly failing to compile for them. Are there any changes that we need for the pipelines?

@heaths
Copy link
Member Author

heaths commented Nov 23, 2022

Yes, there are changes to the pipelines but not that hard. Basically just need to update the same files I'm doing in #32598.

@heaths heaths mentioned this issue Dec 1, 2022
Merged
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Dec 1, 2022
@heaths
Drop netcoreapp3.1, add net7.0 support
f916ead 
Resolves Azure#32596. With netcoreapp3.1 falling out of support soon, we're upgrading to net7.0, net6.0, and, on Windows, net461.
@jsquire jsquire modified the milestones: 2022-12, 2023-02 Dec 14, 2022
@danielmarbach
Copy link
Contributor

Was just about to comment that it might make sense to drop the no longer supported netcoreapp3.1 in the required target frameworks

https://github.com/Azure/azure-sdk-for-net/blob/main/eng/Directory.Build.Common.props#L126

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Jan 10, 2023
@heaths
Drop netcoreapp3.1, add net7.0 support
f5b9c84 
Resolves Azure#32596. With netcoreapp3.1 falling out of support soon, we're upgrading to net7.0, net6.0, and, on Windows, net461.
heaths added a commit that referenced this issue Jan 13, 2023
@heaths
Drop netcoreapp3.1, add net7.0 support (#32814)
0752525 
* Drop netcoreapp3.1, add net7.0 support

Resolves #32596. With netcoreapp3.1 falling out of support soon, we're upgrading to net7.0, net6.0, and, on Windows, net461.

* Resolve PR comments and fix build break

* Tweak platform monikers

* Upgrade to .NET 7.0.101 SDK

Required for microsoft/vstest#4014 fix

* Drop unnecessary runtimes from .vsconfig

* Skip Monitor tests failing under net7.0

Relates to #33403

* Resolve track 1 management plane issues on net7.0

* Resolve Key Vault issues after upgrade to net7.0

* Use different platform guard for management plane

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. MQ This issue is part of a "milestone of quality" initiative.
Projects
Upgrade Azure SDKs for .NET to Latest
Status: Done
Milestone
2023-02
Development

Successfully merging a pull request may close this issue.

Drop netcoreapp3.1, add net7.0 support heaths/azure-sdk-for-net
3 participants
@danielmarbach @jsquire @heaths