Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support projects targetting something other than net452 + netstandard1.4 #3140

Closed
matthchr opened this issue Apr 28, 2017 · 5 comments
Closed
Assignees

Comments

@matthchr
Copy link
Member

For SDK projects it's fine to only build those 2, but for supporting projects that we have (listed below) we sometimes have to target other frameworks.

Here is this list of projects which I would like built but not packaged (tests need not be run either) – note paths are all in my latest PR not in vs17Dev yet:
src\SDKs\Batch\DataPlane\Azure.Batch.IntegrationTests -- targets net452 only because it uses some Certificate stuff that isn't supported in netstandard
src\SDKs\Batch\DataPlane\Azure.Batch.ProtocolTests -- Could maybe port this to target netstandardapp1.1
src\SDKs\Batch\DataPlane\TestCommon\IntegrationTestCommon -- targets net452 only because it uses some Certificate stuff that isn't supported in netstandard
src\SDKs\Batch\DataPlane\Tools\ObjectModelCodeGeneration* -- targets net46 because it uses some Roslyn stuff which only works against net46
src\SDKs\Batch\DataPlane\Tools\ConfigureAwaitAnalyzer – This one you can omit from the build entirely actually, it should only get built if another project references it.

@shahabhijeet shahabhijeet changed the title Support projects targetting something other than net452 + netstandard1.1 Support projects targetting something other than net452 + netstandard1.4 Apr 28, 2017
@shahabhijeet
Copy link
Member

Fixing title

@matthchr
Copy link
Member Author

matthchr commented May 3, 2017

@shahabhijeet I'm just wondering, do you have an idea/plan for dealing with this case?

@matthchr
Copy link
Member Author

@shahabhijeet - Do you have an ETA on when you will support this?

When this work is done, we should make sure to enable the scenario we have with the ConfigureAwaitChecker, where we have a netstandard1.4 Roslyn analyzer which is consumed by our Azure.Batch project (as a development dependency). The analyzer doesn't have a net452 target at all.

@shahabhijeet
Copy link
Member

@matthchr This is under testing and should be done today.

@shahabhijeet
Copy link
Member

Done
#3209

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants