Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed traces need to be added to ServiceBus extension #27969

Closed
alrod opened this issue Nov 16, 2021 · 4 comments
Closed

Distributed traces need to be added to ServiceBus extension #27969

alrod opened this issue Nov 16, 2021 · 4 comments
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@alrod
Copy link
Member

alrod commented Nov 16, 2021

CRI

@ghost ghost assigned brettsam Nov 16, 2021
@nordvall
Copy link

I guess this is the same issue as I just discovered:

When sending a ServiceBus message from a ASP.NET Core application, using the Azure.Messaging.ServiceBus client version 7.5.0, the message gets a "Diagnostic-Id" header that is derived from Activity.Current in the sending process.

However, when receiving the same message with ServiceBusTrigger from ServiceBus extension v. 5.1.0, Activity.Current inside the Azure Function is totally unrelated to the diagnostic id in the incoming message (and Activity.Current.Parent is null). I expected the Activity ID inside the Azure Function to be based on the incoming ID from the message.

The above scenario works as I would expect when you call an Azure Function via the HttpTrigger. Then Activity.Current inside the Azure Function seems to be derived from the incoming http header "traceparent".

Please correct if what I am describing is unrelated to this issue.

@JoshLove-msft
Copy link
Member

The issue here appears to be related to microsoft/ApplicationInsights-dotnet#2151. Once this issue is addressed, the end-to-end tracing should work in the function.

@alrod alrod transferred this issue from Azure/azure-functions-servicebus-extension Apr 4, 2022
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 4, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Service Bus:0.41272017,Extensions:0.18520135,Azure.Identity:0.06257013'

@jsquire
Copy link
Member

jsquire commented Apr 9, 2022

As Josh mentioned, this issue is external to the Service Bus extension and is being tracked by AppInsights in #2151. Closing this out as a duplicate.

@jsquire jsquire closed this as completed Apr 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

No branches or pull requests

7 participants