Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade corresponding SDKs with new JsonConverterHelper for performance matter #26461

Closed
ArthurMa1978 opened this issue Jan 19, 2022 · 3 comments
Closed

Upgrade corresponding SDKs with new JsonConverterHelper for performance matter #26461

ArthurMa1978 opened this issue Jan 19, 2022 · 3 comments
Assignees
@ArthurMa1978
Labels
Mgmt This issue is related to a management-plane library.

Comments

@ArthurMa1978
Copy link
Member

ArthurMa1978 commented Jan 19, 2022 •
edited
Loading

According to #26448, there have a perf issue in the underlining JsonCoverterHelper.
The issue has been fixed, but need to update corresponding SDKs
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 19, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.5374061,Container Registry:0.10148903,Azure.Core:0.028075356'

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 19, 2022
@ArthurMa1978 ArthurMa1978 changed the title Upgrade corresponding Upgrade corresponding SDKs with new JsonConverterHelper for performance matter Jan 19, 2022
@ArthurMa1978 ArthurMa1978 added the Mgmt This issue is related to a management-plane library. label Jan 19, 2022
@ArthurMa1978 ArthurMa1978 self-assigned this Jan 19, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Nov 7, 2023
@nilo19 @zarvd @tonychen15
CodeGen from PR 26483 in Azure/azure-rest-api-specs
5f070d5 
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-10-01 (Azure#26483)

* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-09-01 to version 2023-10-01

* Updates readme

* Updates API version in new specs and examples

* Add rest api specs for node public IP IPtags and IP-based Load Balancers (Azure#26389)

* feat: add rest api spec for node public IP IPTags

* feat: add rest api spec for ip-based load balancer

* Add API spec for AKS HostNetwork NSG Control (Azure#26385)

* update readme (Azure#26388)

* Update custom words for ContainerService/aks 2023-10-01 (Azure#26481)

* add CapacityReservationGroup into custom-words.txt (Azure#26461)

Co-authored-by: tong chen <[email protected]>

* add lower case capacityreservationgroup (Azure#26475)

Co-authored-by: tong chen <[email protected]>

---------

Co-authored-by: Tong Chen <[email protected]>
Co-authored-by: tong chen <[email protected]>

* restored to dev branch base (Azure#26451)

Co-authored-by: tong chen <[email protected]>

* resolve conflict (Azure#26585)

---------

Co-authored-by: Qi Ni <[email protected]>
Co-authored-by: Jialun Cai <[email protected]>
Co-authored-by: Tong Chen <[email protected]>
Co-authored-by: tong chen <[email protected]>
@pallavit
Copy link
Contributor

@ArthurMa1978 is this still valid?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Hi @ArthurMa1978, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArthurMa1978 ArthurMa1978

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pallavit @ArthurMa1978 @azure-sdk