Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete throws error if secret doesn't exist #25125

Closed
lukos opened this issue Nov 4, 2021 · 9 comments
Closed

Delete throws error if secret doesn't exist #25125

lukos opened this issue Nov 4, 2021 · 9 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs feature-request This issue requires a new behavior in the product in order be resolved. KeyVault needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Milestone

Comments

@lukos
Copy link

lukos commented Nov 4, 2021

It is not clear how to delete a secret that might not exist. In most cases, I would definitely expect the default behaviour not to throw an exception if the secret does not exist but at worst, there should be an overload that allows us to ignore the error. Throwing an error means that for every delete, I either need to call GetSecret first or catch and ignore the exception which is nasty.

Also, the link to log a problem about "This Product" is broken.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 4, 2021
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Nov 4, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 4, 2021
@jsquire
Copy link
Member

jsquire commented Nov 4, 2021

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@heaths
Copy link
Member

heaths commented Nov 4, 2021

@rloutlaw could you look into the "This Product" link at the bottom. It's 404'ing.

@heaths heaths added feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Nov 4, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Nov 4, 2021
@heaths heaths added this to the [2022] January milestone Nov 4, 2021
@heaths
Copy link
Member

heaths commented Nov 4, 2021

As for the change request, we could add a DeleteIfExists like we've done in other libraries including Storage. Newer libraries shouldn't throw on delete by default, but the pattern wasn't established for older ones.

That said, we are working on some new features we could take advantage of instead, but are not yet available - should be early next year. We can't change the existing method behavior, though, as that would be a breaking change.

@heaths
Copy link
Member

heaths commented Nov 4, 2021

Note to self: we'd want to specifically handle the case where the initial delete request already 404'd e.g., here. Could also do it in the caller but would then have to duplicate. If we don't mark the operation already-completed, UpdateStatus() would effectively run forever.

heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Jan 31, 2023
@heaths heaths modified the milestones: 2023-02, 2023-03 Jan 31, 2023
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Feb 1, 2023
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Mar 16, 2023
@jsquire jsquire modified the milestones: 2023-03, Backlog Mar 27, 2023
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Mar 28, 2023
@heaths heaths modified the milestones: Backlog, 2023-05 Apr 17, 2023
@heaths heaths modified the milestones: 2023-05, 2023-06 May 11, 2023
@jsquire jsquire modified the milestones: 2023-06, 2023-08 Jul 13, 2023
@jsquire jsquire modified the milestones: 2023-08, Backlog Aug 16, 2023
@pallavit pallavit modified the milestones: Backlog, 2023-10, 2023-11 Sep 14, 2023
@heaths heaths modified the milestones: 2023-11, Backlog Nov 8, 2023
Copy link

github-actions bot commented Mar 4, 2024

Hi @lukos, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
Copy link

github-actions bot commented Apr 5, 2024

Hi @lukos, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Untriaged in Azure SDK for Key Vault Apr 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs feature-request This issue requires a new behavior in the product in order be resolved. KeyVault needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants