Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEARCH] Add support for language auto-detection in OcrSkill #24384

Closed
tiantun opened this issue Oct 4, 2021 · 8 comments
Closed

[SEARCH] Add support for language auto-detection in OcrSkill #24384

tiantun opened this issue Oct 4, 2021 · 8 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Search

Comments

@tiantun
Copy link

tiantun commented Oct 4, 2021

Library or service name.
Microsoft.Azure.Search
Azure.Search.Documents

Is your feature request related to a problem? Please describe.
Enabling auto-detection on the OCR Skill requires setting the "defaultLanguageCode" to "unk". See OCR cognitive skill:
"If the language code is unspecified or null, the language will be set to English. If the language is explicitly set to "unk", the language will be auto-detected."
This seems to be the behaviour since at least early 2019:
Set to "unk" to have system auto-detect language.
However, this is currently not possible in the Search SDKs.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 4, 2021
@tiantun
Copy link
Author

tiantun commented Oct 4, 2021

The code seems to be auto-generated based on /stable/2019-05-06/searchservice.json .
The most recent preview version of this is preview/2020-06-30/searchservice.json .

Created a branch with what seem to be the required changes: Add "unk" value for "OcrSkillLanguage"

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Search labels Oct 4, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 4, 2021
@jsquire
Copy link
Member

jsquire commented Oct 4, 2021

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@Mohit-Chakraborty
Copy link
Contributor

Thanks @tiantun for reporting the issue and suggesting a change to fix the issue.

@Mohit-Chakraborty
Copy link
Contributor

I see a PR has been created against the target branch - Azure/azure-rest-api-specs#16279

@tiantun
Copy link
Author

tiantun commented Oct 6, 2021

Thank you @Mohit-Chakraborty .
Looks like the changes were already merged into the API specs.

Can we keep this one open until the generated code in the SDK is updated as well?
That would simplify tracking of the "unk" value's availability in the SDK.

@Mohit-Chakraborty
Copy link
Contributor

Sure. Since this issue is in the .NET SDK repo, we will keep it open till we consume the change in the SDK.

@salilponde
Copy link

Do we know when this will be available in the SDK?

@Mohit-Chakraborty
Copy link
Contributor

It was added in '11.4.0-beta.6'.
The Changelog has a mention.

I will close the issue. Let me know if there are issues.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Search
Projects
None yet
Development

No branches or pull requests

4 participants