Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Move exception creation functionality out of ClientDiagnostics #24031

Closed
4 tasks
annelo-msft opened this issue Sep 15, 2021 · 4 comments
Closed
4 tasks
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative.
Milestone

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Sep 15, 2021

This needs to be addressed as a part of #23372

  • Add the functionality to new type in Azure.Core
  • Update generator shared source to use new Response-based APIs
  • Update libraries using ClientDiagnostics to move to the new type for exception creation
  • Remove functionality from ClientDiagnostics
@annelo-msft annelo-msft added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Sep 15, 2021
@annelo-msft annelo-msft added this to the [2021] October milestone Sep 15, 2021
@annelo-msft annelo-msft self-assigned this Sep 15, 2021
@annelo-msft annelo-msft changed the title [LLC][Core] Move exception creation functionality from ClientDiagnostics to ResponseClassifier [LLC] [Core] Move exception creation functionality from ClientDiagnostics to ResponseClassifier Sep 15, 2021
@annelo-msft
Copy link
Member Author

annelo-msft commented Sep 15, 2021

@annelo-msft
Copy link
Member Author

Services that have subclassed ClientDiagnostics:

  • sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/ServiceBusClientDiagnostics.cs
  • sdk/textanalytics/Azure.AI.TextAnalytics/src/TextAnalyticsClientDiagnostics.cs
  • sdk/communication/Azure.Communication.PhoneNumbers/src/CommunicationClientDiagnostics.cs
  • sdk/tables/Azure.Data.Tables/src/TablesClientDiagnostics.cs
  • sdk/storage/Azure.Storage.Common/src/Shared/StorageClientDiagnostics.cs

@annelo-msft annelo-msft changed the title [LLC] [Core] Move exception creation functionality from ClientDiagnostics to ResponseClassifier [DPG] [Core] Move exception creation functionality out of ClientDiagnostics Mar 21, 2022
annelo-msft added a commit to annelo-msft/autorest.csharp that referenced this issue Mar 21, 2022
@christothes christothes modified the milestones: Backlog, [2022] May Mar 28, 2022
@annelo-msft annelo-msft modified the milestones: [2022] May, [2022] June Apr 1, 2022
@jsquire jsquire modified the milestones: [2022] June, [2022] July Jun 14, 2022
@jsquire jsquire modified the milestones: 2022-07, 2022-08 Jul 15, 2022
@jsquire jsquire removed this from the 2022-08 milestone Sep 6, 2022
@jsquire jsquire added this to the Backlog milestone Sep 6, 2022
@annelo-msft annelo-msft added MQ This issue is part of a "milestone of quality" initiative. and removed needs-design labels Oct 20, 2022
@annelo-msft
Copy link
Member Author

Work remains to move all libraries to the new implementation and remove the old functionality from ClientDiagnostics - that would be great to do in MQ.

@annelo-msft annelo-msft removed the DPG label Oct 25, 2022
@annelo-msft annelo-msft changed the title [DPG] [Core] Move exception creation functionality out of ClientDiagnostics [Core] Move exception creation functionality out of ClientDiagnostics Oct 25, 2022
@annelo-msft annelo-msft removed their assignment Oct 25, 2022
@heaths heaths modified the milestones: Backlog, 2023-01 Oct 25, 2022
@jsquire jsquire modified the milestones: 2023-01, 2023-02 Jan 19, 2023
@jsquire jsquire modified the milestones: 2023-02, Backlog Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

No branches or pull requests

6 participants