Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing FilteringMessagesBeforePublishing data from ATOM XML payload #21683

Closed
JoshLove-msft opened this issue Jun 8, 2021 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@JoshLove-msft
Copy link
Member

I don't see this exposed in the public APIs of the Azure.Messaging.ServiceBus package though...
Neither in CreateTopicOptions, nor in TopicProperties

Same goes for the TopicDescription in the older .NET package Microsoft.Azure.ServiceBus

It only exists in the even older WindowsAzure.ServiceBus where it was meant to be used only in dev for testing purposes. See TopicDescription.EnableFilteringMessagesBeforePublishing

It is fair to say that we do not plan to carry this forward.

@JoshLove-msft You can remove the dead code in

description.DefaultMessageTimeToLive != TimeSpan.MaxValue ? new XElement(XName.Get("DefaultMessageTimeToLive", AdministrationClientConstants.ServiceBusNamespace), XmlConvert.ToString(description.DefaultMessageTimeToLive)) : null,

Originally posted by @ramya-rao-a in Azure/azure-sdk-for-js#14718 (comment)

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 8, 2021
@JoshLove-msft JoshLove-msft added this to the Backlog milestone Jun 8, 2021
@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jun 8, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 8, 2021
@jsquire jsquire moved this to Needs Costing in Azure SDK for Service Bus Jun 30, 2022
Copy link

github-actions bot commented Mar 4, 2024

Hi @JoshLove-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
Copy link

github-actions bot commented Apr 5, 2024

Hi @JoshLove-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Needs Costing to Done in Azure SDK for Service Bus Apr 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
Status: Done
Development

No branches or pull requests

1 participant