Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] ATOM API: CreateTopicOptions missing field - FilteringMessagesBeforePublishing #14718

Closed
HarshaNalluru opened this issue Apr 5, 2021 · 4 comments
Closed

[Service Bus] ATOM API: CreateTopicOptions missing field - FilteringMessagesBeforePublishing #14718

HarshaNalluru opened this issue Apr 5, 2021 · 4 comments
Assignees
@axisc @richardpark-msft
Labels
Client This issue points to a problem in the data-plane of the library. Service Attention Workflow: This issue is responsible by Azure service team. Service Bus

Comments

@HarshaNalluru
Copy link
Member

FilteringMessagesBeforePublishing is present in .NET but not in JS.
Noticed by @richardpark-msft at #14692
Reference - https://github.com/Azure/azure-sdk-for-net/blob/8af2dfc32c96ef3e340f9d20013bf588d97ea756/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/TopicPropertiesExtensions.cs#L175
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 5, 2021
@HarshaNalluru HarshaNalluru mentioned this issue Apr 5, 2021
Merged
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Apr 5, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 5, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] May milestone Apr 5, 2021
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Apr 6, 2021 •
edited
Loading

@axisc, We see this property in the older WindowsAzure.ServiceBus package, but not in the later Microsoft.Azure.ServiceBus package. See

Can you share if this property is still valid and is worth carrying over to the new libraries for Service Bus?

@ramya-rao-a ramya-rao-a added the Service Attention Workflow: This issue is responsible by Azure service team. label Apr 6, 2021
@ghost
Copy link

ghost commented Apr 6, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl, @axisc.

Issue Details

FilteringMessagesBeforePublishing is present in .NET but not in JS.
Noticed by @richardpark-msft at #14692
Reference - https://github.com/Azure/azure-sdk-for-net/blob/8af2dfc32c96ef3e340f9d20013bf588d97ea756/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/TopicPropertiesExtensions.cs#L175

Author: HarshaNalluru
Assignees: richardpark-msft
Labels:

Client, Service Attention, Service Bus
Milestone: [2021] May

@richardpark-msft richardpark-msft removed this from the [2021] May milestone May 20, 2021
@richardpark-msft
Copy link
Member

Removing milestone pending verification from @axisc that it needs to exist in our track 2 SDKs.

@ramya-rao-a
Copy link
Contributor

I don't see this exposed in the public APIs of the Azure.Messaging.ServiceBus package though...
Neither in CreateTopicOptions, nor in TopicProperties

Same goes for the TopicDescription in the older .NET package Microsoft.Azure.ServiceBus

It only exists in the even older WindowsAzure.ServiceBus where it was meant to be used only in dev for testing purposes. See TopicDescription.EnableFilteringMessagesBeforePublishing

It is fair to say that we do not plan to carry this forward.

@JoshLove-msft You can remove the dead code in https://github.com/Azure/azure-sdk-for-net/blob/8af2dfc32c96ef3e340f9d20013bf588d97ea756/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/TopicPropertiesExtensions.cs#L175

@JoshLove-msft JoshLove-msft mentioned this issue Jun 8, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@axisc axisc

@richardpark-msft richardpark-msft

Labels
Client This issue points to a problem in the data-plane of the library. Service Attention Workflow: This issue is responsible by Azure service team. Service Bus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@axisc @HarshaNalluru @ramya-rao-a @richardpark-msft