Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support locale parameter on recognize receipt methods #14817

Closed
maririos opened this issue Sep 2, 2020 · 2 comments · Fixed by #16026
Closed

Support locale parameter on recognize receipt methods #14817

maririos opened this issue Sep 2, 2020 · 2 comments · Fixed by #16026
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone
[2020] November

Comments

@maririos
Copy link
Member

maririos commented Sep 2, 2020 •
edited
Loading

locale == language?

Optional -> seems like it is to improve the accuracy of the results. (like in TA with language parameter)

Open questions:

  • How does locale affects the returned results? Is there a locale to fields mapping spec?
  • What is the standard called that locale is using?
@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Sep 2, 2020
@maririos maririos added this to the [2020] October milestone Sep 2, 2020
@maririos maririos added the blocking-release Blocks release label Sep 30, 2020
@maririos
Copy link
Member Author

maririos commented Oct 8, 2020

Service team is asking if we could use CultureInfo or an extensible enum for the locale values

@maririos maririos mentioned this issue Oct 9, 2020
Merged
@maririos maririos self-assigned this Oct 15, 2020
@maririos
Copy link
Member Author

Going with strings for now, following what we did in TA.
Having an extensible enum means every time there is a new locale, library needs to update and ship.
Culture info not supported by other languages and not right fit here

@maririos maririos mentioned this issue Oct 16, 2020
Merged
@ghost ghost closed this as completed in #16026 Oct 16, 2020
ghost pushed a commit that referenced this issue Oct 16, 2020
@maririos
[FR] Add locale tests (#16026)
437d9fb 
Fixes: #14817

It also removes `US` from receipts as now it accepts multiple locales
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@maririos @annelo-msft
[FR] Add locale tests (Azure#16026)
6fd625e 
Fixes: Azure#14817

It also removes `US` from receipts as now it accepts multiple locales
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

[FR] Add locale tests maririos/azure-sdk-for-net
1 participant
@maririos