Remove boolean operator prefix requirement for AdditionalTestFilter v…

…ariable
Azure · Aug 3, 2022 · cf7eb12 · cf7eb12
1 parent fad7a95
commit cf7eb12
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/eng/pipelines/templates/jobs/ci.tests.yml b/eng/pipelines/templates/jobs/ci.tests.yml
@@ -65,7 +65,7 @@ jobs:
           NuGetCacheKey: Test
       - script: >-
           dotnet test eng/service.proj
-          --filter "(TestCategory!=Manually) & (TestCategory!=Live) $(AdditionalTestFilters)"
+          --filter "(TestCategory!=Manually) & (TestCategory!=Live) & ($(AdditionalTestFilters))"
           --framework $(TestTargetFramework)
           --logger "trx;LogFileName=$(TestTargetFramework).trx" --logger:"console;verbosity=normal"
           --blame-crash-dump-type full --blame-hang-dump-type full --blame-hang-timeout ${{parameters.TestTimeoutInMinutes}}minutes

diff --git a/eng/pipelines/templates/jobs/live.tests.yml b/eng/pipelines/templates/jobs/live.tests.yml
@@ -123,7 +123,7 @@ jobs:
       - pwsh: >
           dotnet test eng/service.proj
           --framework $(TestTargetFramework)
-          --filter "TestCategory!=Manually $(AdditionalTestFilters)"
+          --filter "TestCategory!=Manually & ($(AdditionalTestFilters))"
           --logger "trx"
           --logger:"console;verbosity=normal"
           --blame-crash-dump-type full --blame-hang-dump-type full --blame-hang-timeout ${{parameters.TimeoutInMinutes}}minutes

diff --git a/eng/pipelines/templates/variables/globals.yml b/eng/pipelines/templates/variables/globals.yml
@@ -20,4 +20,4 @@ variables:
   # Define optional AdditionalTestFilters via pipeline runtime variables or matrix config variables
   # Variable value must start with either & or | to join conditions.
   # See https://docs.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests?pivots=nunit
-  AdditionalTestFilters: ""
+  AdditionalTestFilters: "Placeholder!=DefaultIgnoreMe"
diff --git a/sdk/template/Azure.Template/tests/TemplateClientLiveTests.cs b/sdk/template/Azure.Template/tests/TemplateClientLiveTests.cs
@@ -31,6 +31,7 @@ private TemplateClient CreateClient()
         }
 
         [RecordedTest]
+        [Category("FooBar")]
         public async Task CanGetSecret()
         {
             TemplateClient client = CreateClient();