Make typed property bag methods public (#32851)

Azure · Dec 2, 2022 · cd093d8 · cd093d8
1 parent fd1564a
commit cd093d8
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 5 deletions.
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net461.cs b/sdk/core/Azure.Core/api/Azure.Core.net461.cs
@@ -470,7 +470,9 @@ public HttpMessage(Azure.Core.Request request, Azure.Core.ResponseClassifier res
         public void Dispose() { }
         public System.IO.Stream? ExtractResponseContent() { throw null; }
         public void SetProperty(string name, object value) { }
+        public void SetProperty(System.Type type, object value) { }
         public bool TryGetProperty(string name, out object? value) { throw null; }
+        public bool TryGetProperty(System.Type type, out object? value) { throw null; }
     }
     public enum HttpPipelinePosition
     {

diff --git a/sdk/core/Azure.Core/api/Azure.Core.net5.0.cs b/sdk/core/Azure.Core/api/Azure.Core.net5.0.cs
@@ -470,7 +470,9 @@ public HttpMessage(Azure.Core.Request request, Azure.Core.ResponseClassifier res
         public void Dispose() { }
         public System.IO.Stream? ExtractResponseContent() { throw null; }
         public void SetProperty(string name, object value) { }
+        public void SetProperty(System.Type type, object value) { }
         public bool TryGetProperty(string name, out object? value) { throw null; }
+        public bool TryGetProperty(System.Type type, out object? value) { throw null; }
     }
     public enum HttpPipelinePosition
     {

diff --git a/sdk/core/Azure.Core/api/Azure.Core.net6.0.cs b/sdk/core/Azure.Core/api/Azure.Core.net6.0.cs
@@ -470,7 +470,9 @@ public HttpMessage(Azure.Core.Request request, Azure.Core.ResponseClassifier res
         public void Dispose() { }
         public System.IO.Stream? ExtractResponseContent() { throw null; }
         public void SetProperty(string name, object value) { }
+        public void SetProperty(System.Type type, object value) { }
         public bool TryGetProperty(string name, out object? value) { throw null; }
+        public bool TryGetProperty(System.Type type, out object? value) { throw null; }
     }
     public enum HttpPipelinePosition
     {

diff --git a/sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs b/sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs
@@ -470,7 +470,9 @@ public HttpMessage(Azure.Core.Request request, Azure.Core.ResponseClassifier res
         public void Dispose() { }
         public System.IO.Stream? ExtractResponseContent() { throw null; }
         public void SetProperty(string name, object value) { }
+        public void SetProperty(System.Type type, object value) { }
         public bool TryGetProperty(string name, out object? value) { throw null; }
+        public bool TryGetProperty(System.Type type, out object? value) { throw null; }
     }
     public enum HttpPipelinePosition
     {

diff --git a/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs b/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs
@@ -470,7 +470,9 @@ public HttpMessage(Azure.Core.Request request, Azure.Core.ResponseClassifier res
         public void Dispose() { }
         public System.IO.Stream? ExtractResponseContent() { throw null; }
         public void SetProperty(string name, object value) { }
+        public void SetProperty(System.Type type, object value) { }
         public bool TryGetProperty(string name, out object? value) { throw null; }
+        public bool TryGetProperty(System.Type type, out object? value) { throw null; }
     }
     public enum HttpPipelinePosition
     {

diff --git a/sdk/core/Azure.Core/src/HttpMessage.cs b/sdk/core/Azure.Core/src/HttpMessage.cs
@@ -161,7 +161,7 @@ public void SetProperty(string name, object value)
         /// <param name="type">The property type.</param>
         /// <param name="value">The property value.</param>
         /// <returns><c>true</c> if property exists, otherwise. <c>false</c>.</returns>
-        internal bool TryGetInternalProperty(Type type, out object? value)
+        public bool TryGetProperty(Type type, out object? value)
         {
             value = null;
             return _typeProperties?.TryGetValue(type, out value) == true;
@@ -173,7 +173,7 @@ internal bool TryGetInternalProperty(Type type, out object? value)
         /// </summary>
         /// <param name="type">The key for the value.</param>
         /// <param name="value">The property value.</param>
-        internal void SetInternalProperty(Type type, object value)
+        public void SetProperty(Type type, object value)
         {
             _typeProperties ??= new Dictionary<Type, object>();
             _typeProperties[type] = value;

diff --git a/sdk/core/Azure.Core/src/Pipeline/Internal/TelemetryPolicy.cs b/sdk/core/Azure.Core/src/Pipeline/Internal/TelemetryPolicy.cs
@@ -14,7 +14,7 @@ public TelemetryPolicy(TelemetryDetails telemetryDetails)
 
         public override void OnSendingRequest(HttpMessage message)
         {
-            if (message.TryGetInternalProperty(typeof(UserAgentValueKey), out var userAgent))
+            if (message.TryGetProperty(typeof(UserAgentValueKey), out var userAgent))
             {
                 message.Request.Headers.Add(HttpHeader.Names.UserAgent, ((string)userAgent!));
             }

diff --git a/sdk/core/Azure.Core/src/TelemetryDetails.cs b/sdk/core/Azure.Core/src/TelemetryDetails.cs
@@ -53,7 +53,7 @@ public TelemetryDetails(Assembly assembly, string? applicationId = null)
         /// <param name="message">The <see cref="HttpMessage"/> that will use this <see cref="TelemetryDetails"/>.</param>
         public void Apply(HttpMessage message)
         {
-            message.SetInternalProperty(typeof(UserAgentValueKey), ToString());
+            message.SetProperty(typeof(UserAgentValueKey), ToString());
         }
 
         internal static string GenerateUserAgentString(Assembly clientAssembly, string? applicationId = null)

diff --git a/sdk/core/Azure.Core/tests/TelemetryDetailsTests.cs b/sdk/core/Azure.Core/tests/TelemetryDetailsTests.cs
@@ -57,7 +57,7 @@ public void AppliesToMessage()
 
             target.Apply(message);
 
-            message.TryGetInternalProperty(typeof(UserAgentValueKey), out var obj);
+            message.TryGetProperty(typeof(UserAgentValueKey), out var obj);
             string actualValue = obj as string;
 
             Assert.AreEqual(target.ToString(), actualValue);