Respect SupportsOrdering property (#43531)

* Respect SupportsOrdering property * typo * Add test cases
Azure · Apr 19, 2024 · a6c3e59 · a6c3e59
1 parent 82cc7cf
commit a6c3e59
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 5 deletions.
diff --git a/sdk/servicebus/Azure.Messaging.ServiceBus/CHANGELOG.md b/sdk/servicebus/Azure.Messaging.ServiceBus/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### Bugs Fixed
 
+- Fixed issue where the `SupportOrdering` property was not being respected when set on `CreateTopicOptions`.
+
 ### Other Changes
 
 ## 7.17.5 (2024-04-09)

diff --git a/sdk/servicebus/Azure.Messaging.ServiceBus/assets.json b/sdk/servicebus/Azure.Messaging.ServiceBus/assets.json
@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "net",
   "TagPrefix": "net/servicebus/Azure.Messaging.ServiceBus",
-  "Tag": "net/servicebus/Azure.Messaging.ServiceBus_36f6f28db7"
+  "Tag": "net/servicebus/Azure.Messaging.ServiceBus_2c5f4fe7c3"
 }
diff --git a/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/CreateTopicOptions.cs b/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/CreateTopicOptions.cs
@@ -45,6 +45,7 @@ public CreateTopicOptions(TopicProperties topic)
             Status = topic.Status;
             EnablePartitioning = topic.EnablePartitioning;
             MaxMessageSizeInKilobytes = topic.MaxMessageSizeInKilobytes;
+            SupportOrdering = topic.SupportOrdering;
             if (topic.UserMetadata != null)
             {
                 UserMetadata = topic.UserMetadata;
@@ -233,7 +234,8 @@ public bool Equals(CreateTopicOptions other)
                 && (AuthorizationRules != null && otherOptions.AuthorizationRules != null
                     || AuthorizationRules == null && otherOptions.AuthorizationRules == null)
                 && (AuthorizationRules == null || AuthorizationRules.Equals(otherOptions.AuthorizationRules))
-                && MaxMessageSizeInKilobytes.Equals(other.MaxMessageSizeInKilobytes))
+                && MaxMessageSizeInKilobytes.Equals(other.MaxMessageSizeInKilobytes)
+                && SupportOrdering == otherOptions.SupportOrdering)
             {
                 return true;
             }

diff --git a/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/TopicProperties.cs b/sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/TopicProperties.cs
@@ -45,6 +45,7 @@ internal TopicProperties(CreateTopicOptions options)
             Status = options.Status;
             EnableBatchedOperations = options.EnableBatchedOperations;
             EnablePartitioning = options.EnablePartitioning;
+            SupportOrdering = options.SupportOrdering;
             if (options.UserMetadata != null)
             {
                 UserMetadata = options.UserMetadata;

diff --git a/...us/Azure.Messaging.ServiceBus/tests/Administration/ServiceBusManagementClientLiveTests.cs b/...us/Azure.Messaging.ServiceBus/tests/Administration/ServiceBusManagementClientLiveTests.cs
@@ -223,9 +223,11 @@ await client.GetQueueAsync(queueOptions.Name),
         }
 
         [RecordedTest]
-        [TestCase(false)]
-        [TestCase(true)]
-        public async Task BasicTopicCrudOperations(bool premium)
+        [TestCase(false, false)]
+        [TestCase(false, true)]
+        [TestCase(true, false)]
+        [TestCase(true, true)]
+        public async Task BasicTopicCrudOperations(bool premium, bool supportOrdering)
         {
             var topicName = nameof(BasicTopicCrudOperations).ToLower() + Recording.Random.NewGuid().ToString("D").Substring(0, 8);
             var client = CreateClient(premium);
@@ -240,6 +242,7 @@ public async Task BasicTopicCrudOperations(bool premium)
                 MaxSizeInMegabytes = 1024,
                 RequiresDuplicateDetection = true,
                 UserMetadata = nameof(BasicTopicCrudOperations),
+                SupportOrdering = supportOrdering
             };
 
             if (CanSetMaxMessageSize(premium))