Turn off WarningsAsErrors until we bump System.Text.Json (#44931)

Azure · Jul 10, 2024 · 4c337a8 · 4c337a8
1 parent b6161ec
commit 4c337a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/eng/Directory.Build.Common.props b/eng/Directory.Build.Common.props
@@ -77,7 +77,8 @@
       AZPROVISION001; <!-- Provisioning -->
     </NoWarn>
 
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <!-- Temporarily setting this to false while we resolve the security warning related to System.Text.Json -->
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
     <!-- 
       .NET 8 now produces security warnings for nuget packages in dotnet restore. Keep these as warnings in T1 to avoid needing to update T1 library dependencies.
       See: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/dotnet-restore-audit#recommended-action

diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml
@@ -103,7 +103,7 @@ jobs:
         parameters:
           LogFilePath: $(Build.ArtifactStagingDirectory)/pack.binlog
       - script: >-
-          dotnet pack eng/service.proj -warnaserror
+          dotnet pack eng/service.proj
           /p:ValidateRunApiCompat=true
           /p:SDKType=${{ parameters.SDKType }}
           /p:ServiceDirectory=${{ parameters.ServiceDirectory }}
@@ -239,7 +239,7 @@ jobs:
           LogFilePath: $(Build.ArtifactStagingDirectory)/rebuild.binlog
 
       - script: >-
-          dotnet build eng/service.proj -warnaserror
+          dotnet build eng/service.proj
           /t:rebuild
           /p:DebugType=none
           /p:SDKType=${{ parameters.SDKType }}