Skip to content

Commit

Permalink
Disable code coverage of track 2 mgmt
Browse files Browse the repository at this point in the history
Opened #17090 to track re-enabling once improved.
  • Loading branch information
heaths committed Nov 19, 2020
1 parent 2ed64e9 commit 46eb5f1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion eng/CodeCoverage.targets
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
<CoverageReportCommandLine>$(CoverageReportCommandLine) "-filefilters:+$(CodeCoverageDirectory)\**"</CoverageReportCommandLine>
</PropertyGroup>
<Exec Command="$(CoverageReportCommandLine)"
IgnoreExitCode="true" />
IgnoreExitCode="true"
StandardErrorImportance="high"
StandardOutputImportance="low" />
</Target>

<!--
Expand Down
2 changes: 1 addition & 1 deletion eng/Directory.Build.Data.targets
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
and likely easier to remember than the VSTest platform integration.
Also: https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/KnownIssues.md#1-vstest-stops-process-execution-earlydotnet-test
-->
<PropertyGroup Condition="'$(CollectCoverage)' == 'true' and '$(IsClientLibrary)' == 'true' and '$(IsTestProject)' == 'true' and '$(ExcludeFromCodeCoverage)' != 'true'">
<PropertyGroup Condition="'$(CollectCoverage)' == 'true' and '$(IsClientLibrary)' == 'true' and '$(IsTestProject)' == 'true' and '$(IsMgmtClientLibrary)' != 'true' and '$(ExcludeFromCodeCoverage)' != 'true'">
<_ImportCodeCoverage>true</_ImportCodeCoverage>
<VSTestCollect Condition="'$(VSTestCollect)' == ''">XPlat Code Coverage</VSTestCollect>
<!-- Override this property in your projects' or solutions' Directory.Build.props to further customize code coverage. -->
Expand Down
6 changes: 3 additions & 3 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ jobs:
condition: and(succeededOrFailed(), ne(variables['Skip.Test'], true))
variables:
- template: ../variables/globals.yml
- name: disable.coverage.autogenerate
value: true
# - name: disable.coverage.autogenerate
# value: true
strategy:
maxParallel: $[ variables['MaxParallelTestJobs'] ]
matrix:
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
inputs:
reports: $(Build.SourcesDirectory)\sdk\${{parameters.ServiceDirectory}}\**\coverage.cobertura.xml
targetdir: $(Build.SourcesDirectory)
reporttypes: Cobertura;HtmlSummary
reporttypes: Cobertura
filefilters: +$(Build.SourcesDirectory)\sdk\${{parameters.ServiceDirectory}}\**
verbosity: Verbose
- task: PublishCodeCoverageResults@1
Expand Down

0 comments on commit 46eb5f1

Please sign in to comment.