Skip to content

Commit

Permalink
Resolve PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
heaths committed Feb 1, 2023
1 parent a10a5e8 commit 0ab05fc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
-->
<ItemGroup>
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20230123.3" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20230113.1" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20230131.1" PrivateAssets="All" />
<PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.2" PrivateAssets="All" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ public virtual Response<KeyVaultSecret> GetSecret(string name, string version =
}
}

#pragma warning disable AZC0015 // Unexpected client method return type.
/// <summary>
/// Get a specified secret from a given key vault, but does not throw an exception if the secret does not exist.
/// </summary>
Expand Down Expand Up @@ -207,7 +206,6 @@ public virtual NullableResponse<KeyVaultSecret> GetSecretIfExists(string name, s
throw;
}
}
#pragma warning restore AZC0015 // Unexpected client method return type.

/// <summary>
/// Lists the properties of all enabled and disabled versions of the specified secret. You can use the returned <see cref="SecretProperties.Name"/> and <see cref="SecretProperties.Version"/> in subsequent calls to <see cref="GetSecretAsync"/>.
Expand Down

0 comments on commit 0ab05fc

Please sign in to comment.