Skip to content

Commit

Permalink
Fixed Storage Identity SAS bug and Issue #7309 (#7678)
Browse files Browse the repository at this point in the history
  • Loading branch information
@seanmcc-msft
seanmcc-msft authored Sep 19, 2019
1 parent 3081dd7 commit 05225c3
Show file tree
Hide file tree
Showing 32 changed files with 1,127 additions and 1,090 deletions.
3 changes: 0 additions & 3 deletions sdk/storage/Azure.Storage.Blobs/tests/BlobBaseClientTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,6 @@ public async Task GetPropertiesAsync_ContainerSAS()
}

[Test]
[Ignore("#7309 - upgrading to 2019-02-02")]
public async Task GetPropertiesAsync_ContainerIdentitySAS()
{
BlobServiceClient oauthService = GetServiceClient_OauthAccount();
Expand Down Expand Up @@ -1196,7 +1195,6 @@ public async Task GetPropertiesAsync_BlobSAS()
}

[Test]
[Ignore("#7309 - upgrading to 2019-02-02")]
public async Task GetPropertiesAsync_BlobIdentitySAS()
{
BlobServiceClient oauthService = GetServiceClient_OauthAccount();
Expand Down Expand Up @@ -1256,7 +1254,6 @@ public async Task GetPropertiesAsync_SnapshotSAS()
}

[Test]
[Ignore("#7309 - upgrading to 2019-02-02")]
public async Task GetPropertiesAsync_SnapshotIdentitySAS()
{
BlobServiceClient oauthService = GetServiceClient_OauthAccount();
Expand Down
130 changes: 68 additions & 62 deletions ...ge.Blobs/tests/SessionRecords/BlobBaseClientTests/GetPropertiesAsync_BlobIdentitySAS.json
View file

Large diffs are not rendered by default.

130 changes: 68 additions & 62 deletions ...obs/tests/SessionRecords/BlobBaseClientTests/GetPropertiesAsync_BlobIdentitySASAsync.json
View file

Large diffs are not rendered by default.

64 changes: 32 additions & 32 deletions ...re.Storage.Blobs/tests/SessionRecords/BlobBaseClientTests/GetPropertiesAsync_BlobSAS.json
View file
Original file line number Diff line number Diff line change
@@ -1,52 +1,52 @@
{
"Entries": [
{
"RequestUri": "http:\u002f\u002fgapradev.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05?restype=container",
"RequestUri": "http:\u002f\u002fseandevtest.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05?restype=container",
"RequestMethod": "PUT",
"RequestHeaders": {
"Authorization": "Sanitized",
"Request-Id": "|57b58b66-49d19a402383997b.",
"traceparent": "00-bac2e1e96d7aa84d8c8f80f6edf0569d-5cd380d2e5edf44d-00",
"User-Agent": [
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190912.1\u002b9a86ae3367dccb76004b59b244c982904496250d",
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190918.1\u002b4d11b69d11b884a7ac8d0c95d8a535f61880046a",
"(.NET Core 4.6.27817.01; Microsoft Windows 10.0.18362 )"
],
"x-ms-blob-public-access": "container",
"x-ms-client-request-id": "88ea75bc-faf4-9763-6354-1ea803e45509",
"x-ms-date": "Thu, 12 Sep 2019 23:54:06 GMT",
"x-ms-date": "Wed, 18 Sep 2019 23:56:44 GMT",
"x-ms-return-client-request-id": "true",
"x-ms-version": "2019-02-02"
},
"RequestBody": null,
"StatusCode": 201,
"ResponseHeaders": {
"Content-Length": "0",
"Date": "Thu, 12 Sep 2019 23:54:06 GMT",
"ETag": "\u00220x8D737DC7F8A9984\u0022",
"Last-Modified": "Thu, 12 Sep 2019 23:54:06 GMT",
"Date": "Wed, 18 Sep 2019 23:56:43 GMT",
"ETag": "\u00220x8D73C93DBADC80D\u0022",
"Last-Modified": "Wed, 18 Sep 2019 23:56:43 GMT",
"Server": [
"Windows-Azure-Blob\u002f1.0",
"Microsoft-HTTPAPI\u002f2.0"
],
"x-ms-client-request-id": "88ea75bc-faf4-9763-6354-1ea803e45509",
"x-ms-request-id": "4cdfeeb4-c01e-0044-47c5-691804000000",
"x-ms-request-id": "e7aa5215-301e-0008-097c-6e1179000000",
"x-ms-version": "2019-02-02"
},
"ResponseBody": []
},
{
"RequestUri": "http:\u002f\u002fgapradev.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05\u002ftest-blob-def0b18c-24fd-9303-9938-f32b16b81143",
"RequestUri": "http:\u002f\u002fseandevtest.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05\u002ftest-blob-def0b18c-24fd-9303-9938-f32b16b81143",
"RequestMethod": "PUT",
"RequestHeaders": {
"Authorization": "Sanitized",
"Content-Length": "1024",
"Request-Id": "|57b58b67-49d19a402383997b.",
"traceparent": "00-8968ff5521662947add020faee06edee-f178f1737161aa48-00",
"User-Agent": [
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190912.1\u002b9a86ae3367dccb76004b59b244c982904496250d",
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190918.1\u002b4d11b69d11b884a7ac8d0c95d8a535f61880046a",
"(.NET Core 4.6.27817.01; Microsoft Windows 10.0.18362 )"
],
"x-ms-blob-type": "BlockBlob",
"x-ms-client-request-id": "625a1a01-bbf2-93d2-0df6-9e4d5abd2ac1",
"x-ms-date": "Thu, 12 Sep 2019 23:54:06 GMT",
"x-ms-date": "Wed, 18 Sep 2019 23:56:44 GMT",
"x-ms-return-client-request-id": "true",
"x-ms-version": "2019-02-02"
},
Expand All @@ -55,28 +55,28 @@
"ResponseHeaders": {
"Content-Length": "0",
"Content-MD5": "WGC8KENw4\u002bm4k7wAmvZsXw==",
"Date": "Thu, 12 Sep 2019 23:54:06 GMT",
"ETag": "\u00220x8D737DC7F9833F7\u0022",
"Last-Modified": "Thu, 12 Sep 2019 23:54:06 GMT",
"Date": "Wed, 18 Sep 2019 23:56:43 GMT",
"ETag": "\u00220x8D73C93DBBFC727\u0022",
"Last-Modified": "Wed, 18 Sep 2019 23:56:44 GMT",
"Server": [
"Windows-Azure-Blob\u002f1.0",
"Microsoft-HTTPAPI\u002f2.0"
],
"x-ms-client-request-id": "625a1a01-bbf2-93d2-0df6-9e4d5abd2ac1",
"x-ms-content-crc64": "IixzfyWUMXM=",
"x-ms-request-id": "4cdfeeb6-c01e-0044-48c5-691804000000",
"x-ms-request-id": "e7aa52df-301e-0008-3b7c-6e1179000000",
"x-ms-request-server-encrypted": "true",
"x-ms-version": "2019-02-02"
},
"ResponseBody": []
},
{
"RequestUri": "http:\u002f\u002fgapradev.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05\u002ftest-blob-def0b18c-24fd-9303-9938-f32b16b81143?sv=2018-11-09\u0026st=2019-09-12T22%3A54%3A06Z\u0026se=2019-09-13T00%3A54%3A06Z\u0026sr=b\u0026sp=racwd\u0026sig=Sanitized",
"RequestUri": "http:\u002f\u002fseandevtest.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05\u002ftest-blob-def0b18c-24fd-9303-9938-f32b16b81143?sv=2019-02-02\u0026st=2019-09-18T22%3A56%3A44Z\u0026se=2019-09-19T00%3A56%3A44Z\u0026sr=b\u0026sp=racwd\u0026sig=Sanitized",
"RequestMethod": "HEAD",
"RequestHeaders": {
"Request-Id": "|57b58b68-49d19a402383997b.",
"traceparent": "00-982cf14508889340a98d8f49efa598b9-1b418b587f77f74e-00",
"User-Agent": [
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190912.1\u002b9a86ae3367dccb76004b59b244c982904496250d",
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190918.1\u002b4d11b69d11b884a7ac8d0c95d8a535f61880046a",
"(.NET Core 4.6.27817.01; Microsoft Windows 10.0.18362 )"
],
"x-ms-client-request-id": "4c9838c3-92e7-516d-8317-432a1e5db7cb",
Expand All @@ -90,9 +90,9 @@
"Content-Length": "1024",
"Content-MD5": "WGC8KENw4\u002bm4k7wAmvZsXw==",
"Content-Type": "application\u002foctet-stream",
"Date": "Thu, 12 Sep 2019 23:54:06 GMT",
"ETag": "\u00220x8D737DC7F9833F7\u0022",
"Last-Modified": "Thu, 12 Sep 2019 23:54:06 GMT",
"Date": "Wed, 18 Sep 2019 23:56:43 GMT",
"ETag": "\u00220x8D73C93DBBFC727\u0022",
"Last-Modified": "Wed, 18 Sep 2019 23:56:44 GMT",
"Server": [
"Windows-Azure-Blob\u002f1.0",
"Microsoft-HTTPAPI\u002f2.0"
Expand All @@ -101,49 +101,49 @@
"x-ms-access-tier-inferred": "true",
"x-ms-blob-type": "BlockBlob",
"x-ms-client-request-id": "4c9838c3-92e7-516d-8317-432a1e5db7cb",
"x-ms-creation-time": "Thu, 12 Sep 2019 23:54:06 GMT",
"x-ms-creation-time": "Wed, 18 Sep 2019 23:56:44 GMT",
"x-ms-lease-state": "available",
"x-ms-lease-status": "unlocked",
"x-ms-request-id": "4cdfeeb7-c01e-0044-49c5-691804000000",
"x-ms-request-id": "e7aa531b-301e-0008-717c-6e1179000000",
"x-ms-server-encrypted": "true",
"x-ms-version": "2019-02-02"
},
"ResponseBody": []
},
{
"RequestUri": "http:\u002f\u002fgapradev.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05?restype=container",
"RequestUri": "http:\u002f\u002fseandevtest.blob.core.windows.net\u002ftest-container-b8e767bc-f6e0-6b10-c1a4-d52e1e2a5c05?restype=container",
"RequestMethod": "DELETE",
"RequestHeaders": {
"Authorization": "Sanitized",
"Request-Id": "|57b58b69-49d19a402383997b.",
"traceparent": "00-6b3695b06175894ebebc7cc8c24a6d85-c1f19fa706adc840-00",
"User-Agent": [
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190912.1\u002b9a86ae3367dccb76004b59b244c982904496250d",
"azsdk-net-Storage.Blobs\u002f12.0.0-dev.20190918.1\u002b4d11b69d11b884a7ac8d0c95d8a535f61880046a",
"(.NET Core 4.6.27817.01; Microsoft Windows 10.0.18362 )"
],
"x-ms-client-request-id": "218aad10-de25-77d9-29b1-fd67496478f3",
"x-ms-date": "Thu, 12 Sep 2019 23:54:07 GMT",
"x-ms-date": "Wed, 18 Sep 2019 23:56:44 GMT",
"x-ms-return-client-request-id": "true",
"x-ms-version": "2019-02-02"
},
"RequestBody": null,
"StatusCode": 202,
"ResponseHeaders": {
"Content-Length": "0",
"Date": "Thu, 12 Sep 2019 23:54:06 GMT",
"Date": "Wed, 18 Sep 2019 23:56:43 GMT",
"Server": [
"Windows-Azure-Blob\u002f1.0",
"Microsoft-HTTPAPI\u002f2.0"
],
"x-ms-client-request-id": "218aad10-de25-77d9-29b1-fd67496478f3",
"x-ms-request-id": "4cdfeeb9-c01e-0044-4bc5-691804000000",
"x-ms-request-id": "e7aa5347-301e-0008-187c-6e1179000000",
"x-ms-version": "2019-02-02"
},
"ResponseBody": []
}
],
"Variables": {
"DateTimeOffsetNow": "2019-09-12T16:54:06.9744489-07:00",
"DateTimeOffsetNow": "2019-09-18T16:56:44.2520779-07:00",
"RandomSeed": "122681508",
"Storage_TestConfigDefault": "ProductionTenant\ngapradev\nU2FuaXRpemVk\nhttp:\u002f\u002fgapradev.blob.core.windows.net\nhttp:\u002f\u002fgapradev.file.core.windows.net\nhttp:\u002f\u002fgapradev.queue.core.windows.net\nhttp:\u002f\u002fgapradev.table.core.windows.net\n\n\n\n\nhttp:\u002f\u002fgapradev-secondary.blob.core.windows.net\nhttp:\u002f\u002fgapradev-secondary.file.core.windows.net\nhttp:\u002f\u002fgapradev-secondary.queue.core.windows.net\nhttp:\u002f\u002fgapradev-secondary.table.core.windows.net\n\nSanitized\n\n\nCloud\nBlobEndpoint=http:\u002f\u002fgapradev.blob.core.windows.net\u002f;QueueEndpoint=http:\u002f\u002fgapradev.queue.core.windows.net\u002f;TableEndpoint=http:\u002f\u002fgapradev.table.core.windows.net\u002f;FileEndpoint=http:\u002f\u002fgapradev.file.core.windows.net\u002f;BlobSecondaryEndpoint=http:\u002f\u002fgapradev-secondary.blob.core.windows.net\u002f;QueueSecondaryEndpoint=http:\u002f\u002fgapradev-secondary.queue.core.windows.net\u002f;TableSecondaryEndpoint=http:\u002f\u002fgapradev-secondary.table.core.windows.net\u002f;FileSecondaryEndpoint=http:\u002f\u002fgapradev-secondary.file.core.windows.net\u002f;AccountName=gapradev;AccountKey=Sanitized"
"Storage_TestConfigDefault": "ProductionTenant\nseandevtest\nU2FuaXRpemVk\nhttp:\u002f\u002fseandevtest.blob.core.windows.net\nhttp:\u002f\u002fseandevtest.file.core.windows.net\nhttp:\u002f\u002fseandevtest.queue.core.windows.net\nhttp:\u002f\u002fseandevtest.table.core.windows.net\n\n\n\n\nhttp:\u002f\u002fseandevtest-secondary.blob.core.windows.net\nhttp:\u002f\u002fseandevtest-secondary.file.core.windows.net\nhttp:\u002f\u002fseandevtest-secondary.queue.core.windows.net\nhttp:\u002f\u002fseandevtest-secondary.table.core.windows.net\n\nSanitized\n\n\nCloud\nBlobEndpoint=http:\u002f\u002fseandevtest.blob.core.windows.net\u002f;QueueEndpoint=http:\u002f\u002fseandevtest.queue.core.windows.net\u002f;TableEndpoint=http:\u002f\u002fseandevtest.table.core.windows.net\u002f;FileEndpoint=http:\u002f\u002fseandevtest.file.core.windows.net\u002f;BlobSecondaryEndpoint=http:\u002f\u002fseandevtest-secondary.blob.core.windows.net\u002f;QueueSecondaryEndpoint=http:\u002f\u002fseandevtest-secondary.queue.core.windows.net\u002f;TableSecondaryEndpoint=http:\u002f\u002fseandevtest-secondary.table.core.windows.net\u002f;FileSecondaryEndpoint=http:\u002f\u002fseandevtest-secondary.file.core.windows.net\u002f;AccountName=seandevtest;AccountKey=Sanitized"
}
}
Loading

0 comments on commit 05225c3

Please sign in to comment.