Storage - add ForwardsClientCalls to FileClient.Upload (#7609)

Fixes #7608
Azure · Sep 18, 2019 · 0003c3d · 0003c3d
1 parent ff421ff
commit 0003c3d
Show file tree

Hide file tree

Showing 4 changed files with 423 additions and 0 deletions.
diff --git a/sdk/storage/Azure.Storage.Files/src/FileClient.cs b/sdk/storage/Azure.Storage.Files/src/FileClient.cs
@@ -1869,6 +1869,7 @@ private async Task<Response<StorageFileUploadInfo>> UploadRangeFromUriInternal(
         /// A <see cref="StorageRequestFailedException"/> will be thrown if
         /// a failure occurs.
         /// </remarks>
+        [ForwardsClientCalls]
         public virtual Response<StorageFileUploadInfo> Upload(
             Stream content,
             IProgress<StorageProgress> progressHandler = default,
@@ -1906,6 +1907,7 @@ public virtual Response<StorageFileUploadInfo> Upload(
         /// A <see cref="StorageRequestFailedException"/> will be thrown if
         /// a failure occurs.
         /// </remarks>
+        [ForwardsClientCalls]
         public virtual async Task<Response<StorageFileUploadInfo>> UploadAsync(
             Stream content,
             IProgress<StorageProgress> progressHandler = default,

diff --git a/sdk/storage/Azure.Storage.Files/tests/FileClientTests.cs b/sdk/storage/Azure.Storage.Files/tests/FileClientTests.cs
@@ -848,6 +848,27 @@ await TestHelper.AssertExpectedExceptionAsync<StorageRequestFailedException>(
             }
         }
 
+        [Test]
+        public async Task UploadAsync_Simple()
+        {
+            const int size = 10 * Constants.KB;
+            var data = this.GetRandomBuffer(size);
+            using (this.GetNewShare(out var share))
+            {
+                var name = this.GetNewFileName();
+                var file = this.InstrumentClient(share.GetRootDirectoryClient().GetFileClient(name));
+
+                await file.CreateAsync(size);
+                using var stream = new MemoryStream(data);
+                await file.UploadAsync(stream);
+
+                using var bufferedContent = new MemoryStream();
+                var download = await file.DownloadAsync();
+                await download.Value.Content.CopyToAsync(bufferedContent);
+                TestHelper.AssertSequenceEqual(data, bufferedContent.ToArray());
+            }
+        }
+
         [Test]
         [TestCase(512)]
         [TestCase(1 * Constants.KB)]