Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage] added set expiry #9810

Closed

Conversation

ljian3377
Copy link
Member

Already reviewed in #9560. But have to revert it as it's not supported until STG74.

ljian3377 and others added 30 commits May 21, 2020 15:34
* IReadable

* Avro compiles

* use storage-internal-avro as shared source in storage-blob

* local build config

* test and bug fix

* rename IReadable to AvroReadable, separate the stream implementation with the interface declaration we need different implementation in browsers

* add "private": true to pacakge.json

* use Record

* me

* fix

* tentative: use string enum instead of string union to avoid two copies of constant string

Co-authored-by: Lin Jian <[email protected]>
* fix

* resolve PR comments: remove useless assignment

* AvroReadableFromStream: removeListener when read succeeds

* remove listener when error callback triggered

Co-authored-by: Lin Jian <[email protected]>
* [Storage] Quick query

* [Storage] Quick query API review

* [Storage] Quick query recording

* [Storage] Quick query test case update

* [Storage] Resolve comments
* blob versioning

* support 'bv' SAS

* add response headers to getProperties & api-extract

* fix comments

* add versionId to getBlob response headers

* fix broken undelete test

* undo 'add snapshot to options'

* replace withVersionId() with getURLWithVersionId()

* Revert "replace withVersionId() with getURLWithVersionId()"

This reverts commit eb1d90d.

* hide the versionId option in convenience layer

* add more tests

* fix comments

* change version to preview

* fix merge error

Co-authored-by: Lin Jian <[email protected]>
* fix

* change feed with mininal live tests

* mocking tests

* format code & rename buildAvroReader parameter name

* add README.md

* change eventTime type from string to Date

* Update sdk/storage/storage-blob-changefeed/README.md

Co-authored-by: Jeremy Meng <[email protected]>

* Update sdk/storage/storage-blob-changefeed/README.md

Co-authored-by: Jeremy Meng <[email protected]>

* Update sdk/storage/storage-blob-changefeed/README.md

Co-authored-by: Jeremy Meng <[email protected]>

* PR comments

* Rename eTag to etag in BlobChangeFeedEventData

* remove hns only properties in change event record

* fix minor bug in avro

* Update sdk/storage/storage-blob-changefeed/README.md

Co-authored-by: Brian Terlson <[email protected]>

* Update sdk/storage/storage-blob-changefeed/README.md

Co-authored-by: Brian Terlson <[email protected]>

* rename to BlobChangeFeedGetChangesOptions and fix comments

* update api

Co-authored-by: Lin Jian <[email protected]>
Co-authored-by: Jeremy Meng <[email protected]>
Co-authored-by: Brian Terlson <[email protected]>
* Jumbo putBlock, putBlob, datalake file append

* undo upload ArrayBuffer

* minor edit

Co-authored-by: Lin Jian <[email protected]>
* [Storage] Support blob tags (recording will be added later)

* [Storage] Unify blob tags type Tags everywhere in options and responses

* [Storage] Blob tags - resolve comments
@ljian3377 ljian3377 added the APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. label Jun 30, 2020
@ljian3377 ljian3377 marked this pull request as draft June 30, 2020 13:59
@ljian3377 ljian3377 added APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. and removed APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. labels Sep 3, 2020
@ljian3377 ljian3377 changed the base branch from master to storage/stg74base September 24, 2020 10:52
@ljian3377 ljian3377 force-pushed the ljian/feature/set-expiry branch from 2c653f2 to f288d57 Compare September 24, 2020 10:57
@ljian3377
Copy link
Member Author

Use #11461 instead.

@ljian3377 ljian3377 closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants