Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "@rollup/plugin-commonjs" to ^11.1.0 #9074

Closed
wants to merge 5 commits into from
Closed

Update "@rollup/plugin-commonjs" to ^11.1.0 #9074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ccc59d
Update "@rollup/plugin-commonjs" to ^12.0.0
HarshaNalluru May 21, 2020
a9eb133
"@rollup/plugin-commonjs": "^12.0.0"  ERROR  @rush-temp/abort-control…
HarshaNalluru May 21, 2020
fdaa7a8
pnpm-lock file
HarshaNalluru May 21, 2020
ec125d6
port circular reference fixes from #8642
HarshaNalluru May 21, 2020
3154457
fix Dynamic requires build failure
HarshaNalluru May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 59 additions & 57 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion sdk/appconfiguration/app-configuration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"@azure/identity": "^1.1.0-preview",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/abort-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
},
"devDependencies": {
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-amqp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@microsoft/api-extractor": "7.7.11",
"@azure/identity": "^1.1.0-preview",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-inject": "^4.0.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
"@azure/eslint-plugin-azure-sdk": "^2.0.1",
"@azure/logger-js": "^1.0.2",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-https/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
},
"devDependencies": {
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-lro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"devDependencies": {
"@opentelemetry/api": "^0.6.1",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
9 changes: 7 additions & 2 deletions sdk/core/core-tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@
"LICENSE"
],
"repository": "github:Azure/azure-sdk-for-js",
"keywords": ["azure", "tracing", "Azure", "cloud"],
"keywords": [
"azure",
"tracing",
"Azure",
"cloud"
],
"author": "Microsoft Corporation",
"license": "MIT",
"bugs": {
Expand All @@ -62,7 +67,7 @@
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
},
"devDependencies": {
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-hubs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@azure/identity": "^1.1.0-preview",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-inject": "^4.0.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/event-processor-host/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"devDependencies": {
"@azure/eslint-plugin-azure-sdk": "^2.0.1",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/eventhubs-checkpointstore-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
},
"devDependencies": {
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-inject": "^4.0.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/formrecognizer/ai-form-recognizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"@azure/identity": "^1.1.0-preview",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"@azure/abort-controller": "^1.0.0",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-certificates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"@azure/keyvault-secrets": "^4.1.0-preview.2",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-keys/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"@azure/identity": "^1.1.0-preview",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-secrets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"@azure/identity": "^1.1.0-preview",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/search/search-documents/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
"prettier": "^1.16.4",
"rimraf": "^3.0.0",
"rollup": "^1.16.3",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
Expand Down
2 changes: 1 addition & 1 deletion sdk/servicebus/service-bus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
"@azure/eslint-plugin-azure-sdk": "^3.0.0",
"@azure/identity": "^1.1.0-preview",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-inject": "^4.0.0",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
"puppeteer": "^2.0.0",
"rimraf": "^3.0.0",
"rollup": "^1.16.3",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"rollup-plugin-shim": "^1.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
Expand Down
22 changes: 22 additions & 0 deletions sdk/storage/storage-blob/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ const pkg = require("./package.json");
const depNames = Object.keys(pkg.dependencies);
const production = process.env.NODE_ENV === "production";

// This method throws an error if any circular references are caught,
// this also whitelists non-@azure libraries since such circular references are out of our control.
// More Info - https://github.com/Azure/azure-sdk-for-js/pull/8642#issuecomment-622201377
const overrideOnwarnForTests = (warning, warn) => {
if (warning.code === "CIRCULAR_DEPENDENCY") {
let throwError = true;
if (
warning.message.includes("node_modules") &&
!(
warning.message.includes("node_modules/@azure") ||
warning.message.includes("node_modules\\@azure")
)
) {
throwError = false;
}
if (throwError) throw new Error(warning.message);
}
warn(warning);
};

export function nodeConfig(test = false) {
const externalNodeBuiltins = [
"@azure/core-http",
Expand Down Expand Up @@ -77,6 +97,7 @@ export function nodeConfig(test = false) {
baseConfig.external.push("assert", "fs", "path", "buffer", "zlib");

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down Expand Up @@ -164,6 +185,7 @@ export function browserConfig(test = false) {
baseConfig.external = ["fs-extra"];

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-datalake/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@opentelemetry/api": "^0.6.1",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
22 changes: 22 additions & 0 deletions sdk/storage/storage-file-datalake/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ const pkg = require("./package.json");
const depNames = Object.keys(pkg.dependencies);
const production = process.env.NODE_ENV === "production";

// This method throws an error if any circular references are caught,
// this also whitelists non-@azure libraries since such circular references are out of our control.
// More Info - https://github.com/Azure/azure-sdk-for-js/pull/8642#issuecomment-622201377
const overrideOnwarnForTests = (warning, warn) => {
if (warning.code === "CIRCULAR_DEPENDENCY") {
let throwError = true;
if (
warning.message.includes("node_modules") &&
!(
warning.message.includes("node_modules/@azure") ||
warning.message.includes("node_modules\\@azure")
)
) {
throwError = false;
}
if (throwError) throw new Error(warning.message);
}
warn(warning);
};

export function nodeConfig(test = false) {
const externalNodeBuiltins = [
"@azure/core-http",
Expand Down Expand Up @@ -91,6 +111,7 @@ export function nodeConfig(test = false) {
baseConfig.external.push("assert", "fs", "path");

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down Expand Up @@ -177,6 +198,7 @@ export function browserConfig(test = false) {
baseConfig.external = ["fs-extra"];

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-share/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
"devDependencies": {
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
22 changes: 22 additions & 0 deletions sdk/storage/storage-file-share/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ const pkg = require("./package.json");
const depNames = Object.keys(pkg.dependencies);
const production = process.env.NODE_ENV === "production";

// This method throws an error if any circular references are caught,
// this also whitelists non-@azure libraries since such circular references are out of our control.
// More Info - https://github.com/Azure/azure-sdk-for-js/pull/8642#issuecomment-622201377
const overrideOnwarnForTests = (warning, warn) => {
if (warning.code === "CIRCULAR_DEPENDENCY") {
let throwError = true;
if (
warning.message.includes("node_modules") &&
!(
warning.message.includes("node_modules/@azure") ||
warning.message.includes("node_modules\\@azure")
)
) {
throwError = false;
}
if (throwError) throw new Error(warning.message);
}
warn(warning);
};

export function nodeConfig(test = false) {
const externalNodeBuiltins = [
"@azure/core-http",
Expand Down Expand Up @@ -76,6 +96,7 @@ export function nodeConfig(test = false) {
baseConfig.external.push("assert", "fs", "path", "buffer", "zlib");

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down Expand Up @@ -163,6 +184,7 @@ export function browserConfig(test = false) {
baseConfig.external = ["fs-extra"];

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"@azure/identity": "^1.1.0-preview",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-commonjs": "^11.1.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^7.0.0",
"@rollup/plugin-replace": "^2.2.0",
Expand Down
22 changes: 22 additions & 0 deletions sdk/storage/storage-queue/rollup.base.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,26 @@ const pkg = require("./package.json");
const depNames = Object.keys(pkg.dependencies);
const production = process.env.NODE_ENV === "production";

// This method throws an error if any circular references are caught,
// this also whitelists non-@azure libraries since such circular references are out of our control.
// More Info - https://github.com/Azure/azure-sdk-for-js/pull/8642#issuecomment-622201377
const overrideOnwarnForTests = (warning, warn) => {
if (warning.code === "CIRCULAR_DEPENDENCY") {
let throwError = true;
if (
warning.message.includes("node_modules") &&
!(
warning.message.includes("node_modules/@azure") ||
warning.message.includes("node_modules\\@azure")
)
) {
throwError = false;
}
if (throwError) throw new Error(warning.message);
}
warn(warning);
};

export function nodeConfig(test = false) {
const externalNodeBuiltins = ["@azure/core-http", "crypto", "fs", "os"];
const baseConfig = {
Expand Down Expand Up @@ -68,6 +88,7 @@ export function nodeConfig(test = false) {
baseConfig.external.push("assert", "fs", "path");

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down Expand Up @@ -135,6 +156,7 @@ export function browserConfig(test = false) {
baseConfig.external = ["fs-extra"];

baseConfig.context = "null";
baseConfig.onwarn = overrideOnwarnForTests;

// Disable tree-shaking of test code. In [email protected], rollup started respecting
// the "sideEffects" field in package.json. Since our package.json sets "sideEffects=false", this also
Expand Down
Loading