[KeyVault] Common folder #8866
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| export * from "./src"; | ||
sadasant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| { | ||
| "name": "@azure/keyvault-common", | ||
| "sideEffects": false, | ||
| "private": true, | ||
|
There was a problem hiding this comment. Wouldn't this library need to ship? If so why it is marked private? There was a problem hiding this comment. This is not a library, it's a shared folder that gets built and shipped through the other packages: keyvault-keys, keyvault-secrets and keyvault-certificates. The package.json is there so that VSCode can pick up the dependencies. |
||
| "author": "Microsoft Corporation", | ||
| "version": "1.0.0", | ||
| "license": "MIT", | ||
| "description": "Isomorphic client library for Azure KeyVault's certificates.", | ||
sadasant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "repository": "github:Azure/azure-sdk-for-js", | ||
| "main": "./src/index.ts", | ||
| "module": "dist-esm/index.js", | ||
| "types": "./types/index.d.ts", | ||
| "engines": { | ||
| "node": ">=8.0.0" | ||
| }, | ||
| "scripts": { | ||
| "audit": "node ../../../keyvault-common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit", | ||
|
There was a problem hiding this comment. feels weird that it should go three levels up to come back down to itself There was a problem hiding this comment. I can't think of how to make this better at the moment. There was a problem hiding this comment. am I missing something? or can this line not be There was a problem hiding this comment. oh this is a mistake, it should be common/ not keyvault-common/ Thank you! There was a problem hiding this comment. (this is not part of keyvault-common) There was a problem hiding this comment. I'll skip this script for now |
||
| "build:minify": "uglifyjs -c -m --comments --source-map \"content='./dist/index.js.map'\" -o ./dist/index.min.js ./dist/index.js 2>&1", | ||
| "build:samples": "echo skipped", | ||
| "build:es6": "tsc -p tsconfig.json", | ||
| "build:nodebrowser": "echo skipped", | ||
| "build:test": "echo skipped", | ||
| "build": "npm run extract-api && npm run build:es6 && npm run build:nodebrowser", | ||
| "check-format": "prettier --list-different --config ../../.prettierrc.json \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | ||
| "clean": "rimraf dist-esm dist-test typings *.tgz *.log samples/typescript/dist", | ||
| "execute:js-samples": "echo skipped", | ||
| "execute:ts-samples": "echo skipped", | ||
| "execute:samples": "npm run build:samples && npm run execute:js-samples && npm run execute:ts-samples", | ||
| "extract-api": "echo skipped", | ||
| "format": "prettier --write --config ../../.prettierrc.json \"src/**/*.ts\" \"*.{js,json}\"", | ||
| "integration-test:browser": "echo skipped", | ||
| "integration-test:node": "echo skipped", | ||
| "integration-test:node:no-timeout": "echo skipped", | ||
| "integration-test": "npm run integration-test:node && npm run integration-test:browser", | ||
| "lint:fix": "eslint package.json src --ext .ts --fix --fix-type [problem,suggestion]", | ||
| "lint": "eslint src --ext .ts -f html -o search-lintReport.html || exit 0", | ||
| "lint:terminal": "eslint src --ext .ts", | ||
| "pack": "npm pack 2>&1", | ||
| "prebuild": "npm run clean", | ||
| "test:browser": "npm run clean && npm run build:test && npm run unit-test:browser", | ||
| "test:node": "npm run clean && npm run build:test && npm run unit-test:node", | ||
| "test": "npm run clean && npm run build:test && npm run unit-test", | ||
| "unit-test:browser": "echo skipped", | ||
| "unit-test:node": "echo skipped", | ||
| "unit-test:node:no-timeout": "echo skipped", | ||
| "unit-test": "npm run unit-test:node && npm run unit-test:browser" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/core-http": "^1.1.1", | ||
| "tslib": "^1.10.0" | ||
sadasant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "devDependencies": { | ||
| "typescript": "~3.8.3" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| export * from "./challengeBasedAuthenticationPolicy"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
|
There was a problem hiding this comment. nit: this should extend the common one rather than creating more debt ;) There was a problem hiding this comment. Woah!! Since when??? ;) There was a problem hiding this comment. This should be good now! |
||
| "compilerOptions": { | ||
| "alwaysStrict": true, | ||
| "noImplicitAny": true, | ||
| "preserveConstEnums": true, | ||
| "sourceMap": true, | ||
| "inlineSources": true, | ||
| "newLine": "LF", | ||
| "target": "es5", | ||
| "moduleResolution": "node", | ||
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "strict": true, | ||
| "module": "esNext", | ||
| "outDir": "./dist-esm", | ||
| "declaration": true, | ||
| "declarationMap": true, | ||
| "importHelpers": true, | ||
| "declarationDir": "./types", | ||
| "lib": ["dom", "es5", "es6", "es7", "esnext"], | ||
| "esModuleInterop": true, | ||
| "resolveJsonModule": true | ||
| }, | ||
| "compileOnSave": true, | ||
| "exclude": ["node_modules"], | ||
| "include": ["./src/**/*.ts"] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we have active warnings now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean. This change is needed because the current rules don't work with this project structure. Once this is merged, and after we polish it, I think we will have a good enough idea of how to change the ESLint rules! Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I don't see the point in leaving active warnings in a project. Either we should fix the issue (which in this case I think means fixing the rule?) or disable the rule for now and file an issue to follow-up on turning it back on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(@willmtemple)
Here's the thing:
As we move forward with the test guidelines, we will need to update several things, including the eslint rules. It will take us some time to get there though. I think we would better fix the libraries first, then fix the eslint plugin. What Will did makes sense for our current state. This PR is in an intermediate state.